This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6372

log: remove an unnecessary "and opts.get('rev')" condition
ClosedPublic

Authored by martinvonz on May 14 2019, 12:34 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1ce46f0ee218: log: remove an unnecessary "and opts.get('rev')" condition
rHG9bf6455741c4: log: remove an unnecessary "and opts.get('rev')" condition
Summary

As Yuya pointed out, the condition is unnecessary since
revs.isdescending() would be true if --follow without --rev.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/logcmdutil.py (2 lines)

Diff 15121

mercurial/logcmdutil.py

revs.reverse() revs.reverse()
if filematcher is None: if filematcher is None:
filematcher = _makenofollowfilematcher(repo, pats, opts) filematcher = _makenofollowfilematcher(repo, pats, opts)
if filematcher is None: if filematcher is None:
def filematcher(ctx): def filematcher(ctx):
return match return match
expr = _makerevset(repo, match, pats, slowpath, opts) expr = _makerevset(repo, match, pats, slowpath, opts)
if opts.get('graph') and opts.get('rev'): if opts.get('graph'):
# User-specified revs might be unsorted, but don't sort before # User-specified revs might be unsorted, but don't sort before
# _makerevset because it might depend on the order of revs # _makerevset because it might depend on the order of revs
if not (revs.isdescending() or revs.istopo()): if not (revs.isdescending() or revs.istopo()):
revs.sort(reverse=True) revs.sort(reverse=True)
if expr: if expr:
matcher = revset.match(None, expr) matcher = revset.match(None, expr)
revs = matcher(repo, revs) revs = matcher(repo, revs)
if limit is not None: if limit is not None: