Page MenuHomePhabricator

copies: fix duplicatecopies() with overlay context
ClosedPublic

Authored by martinvonz on May 15 2019, 7:24 PM.

Details

Summary

The reasoning for this check is in 78d760aa3607 (duplicatecopies: do
not mark items not in the dirstate as copies, 2013-03-28). The check
was then moved to workingfilectx in 754b5117622f (context: add
workingfilectx.markcopied, 2017-10-15) and no corresponding check was
added later when overlayworkingfilectx was added. Rather than adding
the check there, this patch adds a more generic check on the callers
side and removes the check in workingfilectx.markcopied().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 15 2019, 7:24 PM
pulkit accepted this revision.May 16 2019, 7:16 AM
This revision was automatically updated to reflect the committed changes.