Page MenuHomePhabricator

help: include subtopic in error message if passed
ClosedPublic

Authored by ngoldbaum on May 23 2019, 11:36 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngoldbaum created this revision.May 23 2019, 11:36 AM
av6 added a subscriber: av6.May 24 2019, 9:06 AM
av6 added inline comments.
mercurial/help.py
819

Concatenating things is not the best option when it comes to i18n, but even if it were, I think it would make sense to only show here the subtopic, if it's provided. If people are curious about internals.foobar (or config.foobar), then hg help -k foobar helps way more than hg help -k internals. And we already make sure that the topic that comes before the dot exists, right?

ngoldbaum added inline comments.May 24 2019, 9:20 AM
mercurial/help.py
819

Fair enough, I agree just the subtopic is fine.

ngoldbaum updated this revision to Diff 15253.May 24 2019, 9:28 AM
ngoldbaum updated this revision to Diff 15259.May 25 2019, 7:54 AM
ngoldbaum updated this revision to Diff 15269.May 26 2019, 5:06 PM
pulkit accepted this revision.Wed, May 29, 1:24 PM
This revision was automatically updated to reflect the committed changes.