Page MenuHomePhabricator

dagop: fix documentation of reachableroots
ClosedPublic

Authored by valentin.gatienbaron on Mon, Jun 10, 12:46 PM.

Details

Summary

The previous revset couldn't be correct as it is symmetric in <roots>
and <heads>, but reachableroots has no such symmetry. It makes a
difference with for instance reachableroots(2, 3) where 2 and 3 are
both children of 1.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit added a subscriber: pulkit.Mon, Jun 10, 7:07 PM
pulkit added inline comments.
mercurial/dagop.py
265

if this doc about includepath was correct, let's keep it.

pulkit added inline comments.Mon, Jun 10, 7:14 PM
mercurial/dagop.py
265

ignore me here, now I saw the next patch.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.