Page MenuHomePhabricator

phabricator: add --blocker argument to phabsend to specify blocking reviewers
ClosedPublic

Authored by Kwan on Tue, Jun 11, 2:28 PM.

Details

Summary

The way to signal to Conduit that a reviewer is considered blocking is just to
wrap their PHID in "blocking()" when including it in the list of PHIDs passed
to reviewers.add.

arc doesn't have a --blocker, instead one is supposed to append a '!' to the
end of reviewer names (I think reviewers are usually added in an editor rather
than the command line, where '!'s can be more hazardous).

moz-phab (Mozilla's arcanist wrapper) does have a --blocker argument, and being
explicit like this is also more discoverable. Even arc diff's help doesn't
seem to mention the reviewer! syntax.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Tue, Jun 11, 2:28 PM
Kwan retitled this revision from phabricator: add a --blocker argument to phabsend to specify blocking reviewers to phabricator: add --blocker argument to phabsend to specify blocking reviewers.Tue, Jun 11, 2:55 PM
mharbison72 accepted this revision.Wed, Jun 12, 12:37 PM

LGTM. Thanks for doing this.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.