( )⚙ D651 blackbox: remove _bbvfs state

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D651

blackbox: remove _bbvfs state
ClosedPublic

Authored by quark on Sep 7 2017, 1:32 AM.

Details

Reviewers
durham
Group Reviewers
hg-reviewers
Commits
rHG029b33adbd17: blackbox: remove _bbvfs state
Summary

_bbvfs is redundant because it could be calcualted from _bbrepo.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Sep 7 2017, 1:32 AM
durham accepted this revision.Sep 7 2017, 8:19 PM
durham added inline comments.
hgext/blackbox.py
100

I'd probably explicitly return None instead of relying on the implicit return value.

Closed by commit rHG029b33adbd17: blackbox: remove _bbvfs state (authored by quark). · Explain WhySep 12 2017, 10:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/blackbox.py (11 lines)

Diff 1654

hgext/blackbox.py

class blackboxui(ui.__class__): class blackboxui(ui.__class__):
def __init__(self, src=None): def __init__(self, src=None):
super(blackboxui, self).__init__(src) super(blackboxui, self).__init__(src)
if src is None: if src is None:
self._partialinit() self._partialinit()
else: else:
self._bbinlog = False self._bbinlog = False
self._bbrepo = getattr(src, '_bbrepo', None) self._bbrepo = getattr(src, '_bbrepo', None)
self._bbvfs = getattr(src, '_bbvfs', None)
def _partialinit(self): def _partialinit(self):
if util.safehasattr(self, '_bbvfs'): if self._bbvfs:
return return
self._bbinlog = False self._bbinlog = False
self._bbrepo = None self._bbrepo = None
self._bbvfs = None
def copy(self): def copy(self):
self._partialinit() self._partialinit()
return self.__class__(self) return self.__class__(self)
@property
def _bbvfs(self):
repo = getattr(self, '_bbrepo', None)
if repo:
return repo.vfs
durhamUnsubmitted
Not Done

I'd probably explicitly return None instead of relying on the implicit return value.

durham: I'd probably explicitly return None instead of relying on the implicit return value.
@util.propertycache @util.propertycache
def track(self): def track(self):
return self.configlist('blackbox', 'track', ['*']) return self.configlist('blackbox', 'track', ['*'])
def _openlogfile(self): def _openlogfile(self):
def rotate(oldpath, newpath): def rotate(oldpath, newpath):
try: try:
self._bbvfs.unlink(newpath) self._bbvfs.unlink(newpath)
else: else:
ui._bbinlog = False ui._bbinlog = False
finally: finally:
pass pass
def setrepo(self, repo): def setrepo(self, repo):
self._bbinlog = False self._bbinlog = False
self._bbrepo = repo self._bbrepo = repo
self._bbvfs = repo.vfs
ui.__class__ = blackboxui ui.__class__ = blackboxui
uimod.ui = blackboxui uimod.ui = blackboxui
def uisetup(ui): def uisetup(ui):
wrapui(ui) wrapui(ui)
def reposetup(ui, repo): def reposetup(ui, repo):