This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6523

demandimport: add tracing coverage for Python 3
ClosedPublic

Authored by durin42 on Jun 12 2019, 5:07 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGadb636392b3f: demandimport: add tracing coverage for Python 3
Summary

This makes things feel a little less mysterious when modules are being
imported.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jun 12 2019, 5:07 PM
pulkit accepted this revision.Jun 14 2019, 7:01 PM
This revision is now accepted and ready to land.Jun 14 2019, 7:01 PM
durin42 added a commit: rHGadb636392b3f: demandimport: add tracing coverage for Python 3.Jun 14 2019, 7:15 PM
Closed by commit rHGadb636392b3f: demandimport: add tracing coverage for Python 3 (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgdemandimport/demandimportpy3.py (11 lines)

Diff 15523

hgdemandimport/demandimportpy3.py

from __future__ import absolute_import from __future__ import absolute_import
import contextlib import contextlib
import importlib.abc import importlib.abc
import importlib.machinery import importlib.machinery
import importlib.util import importlib.util
import sys import sys
from . import tracing
_deactivated = False _deactivated = False
class _lazyloaderex(importlib.util.LazyLoader): class _lazyloaderex(importlib.util.LazyLoader):
"""This is a LazyLoader except it also follows the _deactivated global and """This is a LazyLoader except it also follows the _deactivated global and
the ignore list. the ignore list.
""" """
def exec_module(self, module): def exec_module(self, module):
"""Make the module load lazily.""" """Make the module load lazily."""
with tracing.log('demandimport %s', module):
if _deactivated or module.__name__ in ignores: if _deactivated or module.__name__ in ignores:
self.loader.exec_module(module) self.loader.exec_module(module)
else: else:
super().exec_module(module) super().exec_module(module)
# This is 3.6+ because with Python 3.5 it isn't possible to lazily load # This is 3.6+ because with Python 3.5 it isn't possible to lazily load
# extensions. See the discussion in https://bugs.python.org/issue26186 for more. # extensions. See the discussion in https://bugs.python.org/issue26186 for more.
_extensions_loader = _lazyloaderex.factory( _extensions_loader = _lazyloaderex.factory(
importlib.machinery.ExtensionFileLoader) importlib.machinery.ExtensionFileLoader)
_bytecode_loader = _lazyloaderex.factory( _bytecode_loader = _lazyloaderex.factory(
importlib.machinery.SourcelessFileLoader) importlib.machinery.SourcelessFileLoader)
_source_loader = _lazyloaderex.factory(importlib.machinery.SourceFileLoader) _source_loader = _lazyloaderex.factory(importlib.machinery.SourceFileLoader)