( )⚙ D6541 remotefilelog: check if RFL is enabled in getrenamedfn() override

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6541

remotefilelog: check if RFL is enabled in getrenamedfn() override
ClosedPublic

Authored by martinvonz on Jun 19 2019, 2:31 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf93762f251d2: remotefilelog: check if RFL is enabled in getrenamedfn() override
Summary

In 8a0e03f7baf4 (remotefilelog: move most setup from onetimesetup() to
uisetup(), 2019-05-01), I said:

All the wrappers moved in this patch check if remotefilelog is enabled
before they change behavior, so it's safe to always wrap.

That was clearly a lie, because getrenamedfn() didn't. That made
e.g. hg log -T {file_copies} unbearably slow. This patch fixes that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mhgext/remotefilelog/__init__.py (7 lines)

Diff 15591

hgext/remotefilelog/__init__.py

extensions.wrapfunction(repair, '_collectbrokencsets', _collectbrokencsets) extensions.wrapfunction(repair, '_collectbrokencsets', _collectbrokencsets)
extensions.wrapfunction(context.changectx, 'filectx', filectx) extensions.wrapfunction(context.changectx, 'filectx', filectx)
extensions.wrapfunction(context.workingctx, 'filectx', workingfilectx) extensions.wrapfunction(context.workingctx, 'filectx', workingfilectx)
extensions.wrapfunction(patch, 'trydiff', trydiff) extensions.wrapfunction(patch, 'trydiff', trydiff)
extensions.wrapfunction(hg, 'verify', _verify) extensions.wrapfunction(hg, 'verify', _verify)
scmutil.fileprefetchhooks.add('remotefilelog', _fileprefetchhook) scmutil.fileprefetchhooks.add('remotefilelog', _fileprefetchhook)
# disappointing hacks below # disappointing hacks below
scmutil.getrenamedfn = getrenamedfn extensions.wrapfunction(scmutil, 'getrenamedfn', getrenamedfn)
extensions.wrapfunction(revset, 'filelog', filelogrevset) extensions.wrapfunction(revset, 'filelog', filelogrevset)
revset.symbols['filelog'] = revset.filelog revset.symbols['filelog'] = revset.filelog
extensions.wrapfunction(cmdutil, 'walkfilerevs', walkfilerevs) extensions.wrapfunction(cmdutil, 'walkfilerevs', walkfilerevs)
def cloneshallow(orig, ui, repo, *args, **opts): def cloneshallow(orig, ui, repo, *args, **opts):
if opts.get(r'shallow'): if opts.get(r'shallow'):
repos = [] repos = []
# but still do a sanity check about pending multiple revisions # but still do a sanity check about pending multiple revisions
if len(set(x[3] for x in pendingfilecommits)) > 1: if len(set(x[3] for x in pendingfilecommits)) > 1:
raise error.ProgrammingError( raise error.ProgrammingError(
'pending multiple integer revisions are not supported') 'pending multiple integer revisions are not supported')
del pendingfilecommits[:] del pendingfilecommits[:]
return node return node
extensions.wrapfunction(changelog.changelog, 'add', changelogadd) extensions.wrapfunction(changelog.changelog, 'add', changelogadd)
def getrenamedfn(repo, endrev=None): def getrenamedfn(orig, repo, endrev=None):
if not isenabled(repo):
return orig(repo, endrev)
rcache = {} rcache = {}
def getrenamed(fn, rev): def getrenamed(fn, rev):
'''looks up all renames for a file (up to endrev) the first '''looks up all renames for a file (up to endrev) the first
time the file is given. It indexes on the changerev and only time the file is given. It indexes on the changerev and only
parses the manifest if linkrev != changerev. parses the manifest if linkrev != changerev.
Returns rename info for fn at changerev rev.''' Returns rename info for fn at changerev rev.'''
if rev in rcache.setdefault(fn, {}): if rev in rcache.setdefault(fn, {}):