( )⚙ D6565 drawdag: don't crash when writing copy info to changesets

This is an archive of the discontinued Mercurial Phabricator instance.

drawdag: don't crash when writing copy info to changesets
ClosedPublic

Authored by martinvonz on Jun 21 2019, 1:01 PM.

Details

Summary

When writing copies to the changeset, localrepo.commitctx() will call
ctx.p1copies() and ctx.p2copies(). These crashed on simplecommitctx
because they ended up trying to access the manifest. drawdag doesn't
support copies at all, so we can simply override the methods to return
empty dicts.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jun 21 2019, 1:01 PM
pulkit accepted this revision.Jun 22 2019, 9:22 AM
This revision is now accepted and ready to land.Jun 22 2019, 9:22 AM