This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6596

unshelve: add interactive mode
ClosedPublic

Authored by navaneeth.suresh on Jul 2 2019, 8:43 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5162753c4c14: unshelve: add interactive mode
rHG62953fd58404: unshelve: add interactive mode
Summary

Until now, there is no way to unshelve selected changes only from
the stored shelve as given in issue6162. This patch makes unshelve
perform with certain changes only by adding an interactive mode.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Jul 2 2019, 8:56 AM

Didn't look at the actual implementation yet.

mercurial/shelve.py
990

The interactive flag should work the same way as it work for revert, commit and shelve commands. That's either ask hunk by hunk or pop up a curses UI.

As you suggested before, maybe we can have -f flag to specify files to unshelve.

tests/test-shelve.t
1204

add a comment here specifying that shelve should not contain c now.

navaneeth.suresh marked an inline comment as done.Jul 2 2019, 9:18 AM
navaneeth.suresh updated this revision to Diff 15739.
navaneeth.suresh added inline comments.Jul 2 2019, 9:19 AM
mercurial/shelve.py
990

will fix this in the next-to-next revision.

pulkit added inline comments.Jul 2 2019, 5:53 PM
mercurial/shelve.py
990

To have this patch in a good state to be reviewed, it will be nice you take out the addition of interactive flag to the patch where you add that functionality.

navaneeth.suresh retitled this revision from unshelve: add interactive mode (issue6162) to unshelve: make unshelve accept files (issue6162).Jul 4 2019, 10:49 AM
navaneeth.suresh edited the summary of this revision. (Show Details)
navaneeth.suresh updated this revision to Diff 15757.
navaneeth.suresh marked 2 inline comments as done.Jul 4 2019, 10:51 AM
navaneeth.suresh added inline comments.
mercurial/shelve.py
990

Updated the patch by replacing the --interactive flag with --files.

navaneeth.suresh marked an inline comment as done.Jul 4 2019, 10:52 AM
pulkit added inline comments.Jul 6 2019, 7:38 PM
mercurial/shelve.py
842

We can do filtering of files to unshelve here.

Before this repo.commit we have all the changes, we first commit which are needed to be unshelve, then create a shelve of rest of the changes.

pulkit added a comment.Jul 11 2019, 9:18 AM

It will be nice to add information to commit message about how thing unshelving of a subset works.

mercurial/shelve.py
1013–1014

Can you explain why we are not processing this if files are present?

navaneeth.suresh marked 2 inline comments as done.Jul 11 2019, 9:24 AM
navaneeth.suresh added inline comments.
mercurial/shelve.py
1013–1014

okay. on unshelving with --files flag, we don't want to clear the shelvedstate unless all the files in the shelvectx is same as the files which are requested by the user. on unshelving without --files flag, we can clear the shelvedstate right away. that's why i have used this condition.

navaneeth.suresh marked an inline comment as done.Jul 11 2019, 9:25 AM
navaneeth.suresh edited the summary of this revision. (Show Details)Jul 11 2019, 9:33 AM
navaneeth.suresh retitled this revision from unshelve: make unshelve accept files (issue6162) to unshelve: add interactive mode.Jul 11 2019, 2:55 PM
navaneeth.suresh edited the summary of this revision. (Show Details)
navaneeth.suresh updated this revision to Diff 15890.
navaneeth.suresh edited the summary of this revision. (Show Details)Jul 12 2019, 3:46 AM
navaneeth.suresh updated this revision to Diff 15891.
navaneeth.suresh added a commit: rHG62953fd58404: unshelve: add interactive mode.Jul 17 2019, 7:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG62953fd58404: unshelve: add interactive mode (authored by navaneeth.suresh). · Explain Why
This revision was automatically updated to reflect the committed changes.
pulkit added inline comments.Jul 18 2019, 12:50 AM
mercurial/commands.py
6162

Can you mark this as EXPERIMENTAL because right now we rebases the whole commit, which leads to conflicts in files which the user might not want to unshelve.

tests/test-shelve.t
1351

We should store information about --interacive in shelve state, which will help us to prevent passing -i here again.

navaneeth.suresh added inline comments.Jul 18 2019, 11:21 AM
mercurial/commands.py
6162

Doing that right away! Will solve this issue later.

tests/test-shelve.t
1351

We only pass -i if we want to do the unshelve interactively again. It's not mandatory to do that. After an interactive shelve, the stored remaining shelve is same as a normal shelve. We can unshelve it without the -i. So, I don't think we have to do that.

pulkit added inline comments.Jul 18 2019, 1:19 PM
tests/test-shelve.t
1351

Looking at the test case:

User wants to interactively unshelve, runs hg unshelve -i. They hit conflicts, resolve conflicts, and then run hg unshelve --continue.

Here, user intended to do an interactive unshelve, and having conflicts should not change what user wanted. Also this is similar to other commands. We preserve the flags which user passed and follow them when the operation is continued.

pulkit added a comment.Jul 23 2019, 9:49 AM

For record: I left more comments about this patch. Mistakenly I did them on the phabricator commit instead of this review. https://phab.mercurial-scm.org/rHG5162753c4c14c143e6be011b89d6567b5ef50d66#51172

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)
Mmercurial/shelve.py (73 lines)
Mtests/test-completion.t (2 lines)
Mtests/test-shelve.t (64 lines)

Diff 15739

mercurial/commands.py

return postincoming(ui, repo, modheads, opts.get(r'update'), None, None) return postincoming(ui, repo, modheads, opts.get(r'update'), None, None)
@command('unshelve', @command('unshelve',
[('a', 'abort', None, [('a', 'abort', None,
_('abort an incomplete unshelve operation')), _('abort an incomplete unshelve operation')),
('c', 'continue', None, ('c', 'continue', None,
_('continue an incomplete unshelve operation')), _('continue an incomplete unshelve operation')),
('i', 'interactive', None,
_('use interactive mode')),
pulkitUnsubmitted
Not Done

Can you mark this as EXPERIMENTAL because right now we rebases the whole commit, which leads to conflicts in files which the user might not want to unshelve.

pulkit: Can you mark this as `EXPERIMENTAL` because right now we rebases the whole commit, which leads…
navaneeth.sureshAuthorUnsubmitted
Done

Doing that right away! Will solve this issue later.

navaneeth.suresh: Doing that right away! Will solve this issue later.
('k', 'keep', None, ('k', 'keep', None,
_('keep shelve after unshelving')), _('keep shelve after unshelving')),
('n', 'name', '', ('n', 'name', '',
_('restore shelved change with given name'), _('NAME')), _('restore shelved change with given name'), _('NAME')),
('t', 'tool', '', _('specify merge tool')), ('t', 'tool', '', _('specify merge tool')),
('', 'date', '', ('', 'date', '',
_('set date for temporary commits (DEPRECATED)'), _('DATE'))], _('set date for temporary commits (DEPRECATED)'), _('DATE'))],
_('hg unshelve [[-n] SHELVED]'), _('hg unshelve [[-n] SHELVED]'),

mercurial/shelve.py

from .i18n import _ from .i18n import _
from . import ( from . import (
bookmarks, bookmarks,
bundle2, bundle2,
bundlerepo, bundlerepo,
changegroup, changegroup,
cmdutil, cmdutil,
context,
copies as copiesmod,
discovery, discovery,
error, error,
exchange, exchange,
hg, hg,
lock as lockmod, lock as lockmod,
mdiff, mdiff,
merge, merge,
node as nodemod, node as nodemod,
tempopts = {} tempopts = {}
tempopts['message'] = "pending changes temporary commit" tempopts['message'] = "pending changes temporary commit"
tempopts['date'] = opts.get('date') tempopts['date'] = opts.get('date')
with ui.configoverride({('ui', 'quiet'): True}): with ui.configoverride({('ui', 'quiet'): True}):
node = cmdutil.commit(ui, repo, commitfunc, [], tempopts) node = cmdutil.commit(ui, repo, commitfunc, [], tempopts)
tmpwctx = repo[node] tmpwctx = repo[node]
return tmpwctx, addedbefore return tmpwctx, addedbefore
def _commitfiltered(repo, ctx, match, keepcommit):
"""Recommit ctx with changed files not in match. Return the new
node identifier, or None if nothing changed.
"""
base = ctx.p1()
# ctx
initialfiles = set(ctx.files())
files = set(f for f in initialfiles if match(f))
# return the p1 so that we don't create an obsmarker later
if not keepcommit:
return ctx.p1().node()
# Filter copies
copied = copiesmod.pathcopies(base, ctx)
copied = dict((dst, src) for dst, src in copied.iteritems()
if dst in files)
def filectxfn(repo, memctx, path, contentctx=ctx, redirect=()):
if path not in contentctx:
return None
fctx = contentctx[path]
mctx = context.memfilectx(repo, memctx, fctx.path(), fctx.data(),
fctx.islink(),
fctx.isexec(),
copysource=copied.get(path))
return mctx
if not files:
repo.ui.status(_("note: keeping empty commit\n"))
new = context.memctx(repo,
parents=[base.node(), nodemod.nullid],
text=ctx.description(),
files=files,
filectxfn=filectxfn,
user=ctx.user(),
date=ctx.date(),
extra=ctx.extra())
return repo[repo.commitctx(new)]
def _unshelverestorecommit(ui, repo, tr, basename): def _unshelverestorecommit(ui, repo, tr, basename):
"""Recreate commit in the repository during the unshelve""" """Recreate commit in the repository during the unshelve"""
repo = repo.unfiltered() repo = repo.unfiltered()
node = None node = None
if shelvedfile(repo, basename, 'shelve').exists(): if shelvedfile(repo, basename, 'shelve').exists():
node = shelvedfile(repo, basename, 'shelve').readinfo()['node'] node = shelvedfile(repo, basename, 'shelve').readinfo()['node']
if node is None or node not in repo: if node is None or node not in repo:
with ui.configoverride({('ui', 'quiet'): True}): with ui.configoverride({('ui', 'quiet'): True}):
shelvedstate.save(repo, basename, pctx, tmpwctx, nodestoremove, shelvedstate.save(repo, basename, pctx, tmpwctx, nodestoremove,
branchtorestore, opts.get('keep'), activebookmark) branchtorestore, opts.get('keep'), activebookmark)
raise error.InterventionRequired( raise error.InterventionRequired(
_("unresolved conflicts (see 'hg resolve', then " _("unresolved conflicts (see 'hg resolve', then "
"'hg unshelve --continue')")) "'hg unshelve --continue')"))
with repo.dirstate.parentchange(): with repo.dirstate.parentchange():
repo.setparents(tmpwctx.node(), nodemod.nullid) repo.setparents(tmpwctx.node(), nodemod.nullid)
newnode = repo.commit(text=shelvectx.description(), newnode = repo.commit(text=shelvectx.description(),
pulkitUnsubmitted
Done

We can do filtering of files to unshelve here.

Before this repo.commit we have all the changes, we first commit which are needed to be unshelve, then create a shelve of rest of the changes.

pulkit: We can do filtering of files to unshelve here. Before this `repo.commit` we have all the…
extra=shelvectx.extra(), extra=shelvectx.extra(),
user=shelvectx.user(), user=shelvectx.user(),
date=shelvectx.date()) date=shelvectx.date())
if newnode is None: if newnode is None:
# If it ended up being a no-op commit, then the normal # If it ended up being a no-op commit, then the normal
# merge state clean-up path doesn't happen, so do it # merge state clean-up path doesn't happen, so do it
# here. Fix issue5494 # here. Fix issue5494
m = _("shelved change touches missing files") m = _("shelved change touches missing files")
hint = _("run hg status to see which files are missing") hint = _("run hg status to see which files are missing")
raise error.Abort(m, hint=hint) raise error.Abort(m, hint=hint)
def _dounshelve(ui, repo, *shelved, **opts): def _dounshelve(ui, repo, *shelved, **opts):
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
abortf = opts.get('abort') abortf = opts.get('abort')
continuef = opts.get('continue') continuef = opts.get('continue')
interactive = opts.get('interactive')
if not abortf and not continuef: if not abortf and not continuef:
cmdutil.checkunfinished(repo) cmdutil.checkunfinished(repo)
shelved = list(shelved) shelved = list(shelved)
if opts.get("name"): if opts.get("name"):
shelved.append(opts["name"]) shelved.append(opts["name"])
if abortf or continuef: if abortf or continuef:
if abortf and continuef: if abortf and continuef:
branchtorestore = '' branchtorestore = ''
if shelvectx.branch() != shelvectx.p1().branch(): if shelvectx.branch() != shelvectx.p1().branch():
branchtorestore = shelvectx.branch() branchtorestore = shelvectx.branch()
shelvectx = _rebaserestoredcommit(ui, repo, opts, tr, oldtiprev, shelvectx = _rebaserestoredcommit(ui, repo, opts, tr, oldtiprev,
basename, pctx, tmpwctx, basename, pctx, tmpwctx,
shelvectx, branchtorestore, shelvectx, branchtorestore,
activebookmark) activebookmark)
files = shelvectx.files()
filesinclude = []
filesexclude = []
pulkitUnsubmitted
Done

The interactive flag should work the same way as it work for revert, commit and shelve commands. That's either ask hunk by hunk or pop up a curses UI.

As you suggested before, maybe we can have -f flag to specify files to unshelve.

pulkit: The interactive flag should work the same way as it work for revert, commit and shelve commands.
navaneeth.sureshAuthorUnsubmitted
Done

will fix this in the next-to-next revision.

navaneeth.suresh: will fix this in the next-to-next revision.
pulkitUnsubmitted
Done

To have this patch in a good state to be reviewed, it will be nice you take out the addition of interactive flag to the patch where you add that functionality.

pulkit: To have this patch in a good state to be reviewed, it will be nice you take out the addition of…
navaneeth.sureshAuthorUnsubmitted
Done

Updated the patch by replacing the --interactive flag with --files.

navaneeth.suresh: Updated the patch by replacing the `--interactive` flag with `--files`.
if interactive:
for file in files:
choice = ui.promptchoice(
_('unshelve changes in file %s (Yn)?$$ &Yes $$ &No')
% file)
if choice == 0:
filesinclude.append(file)
else:
filesexclude.append(file)
match = scmutil.match(shelvectx, filesinclude, {})
match2 = scmutil.match(shelvectx, filesexclude, {})
shelvectxbackup = shelvectx
shelvectx = _commitfiltered(repo, shelvectx, match,
keepcommit=True)
shelvectxnew = _commitfiltered(repo, shelvectxbackup, match2,
keepcommit=True)
_shelvecreatedcommit(repo, shelvectxnew.node(), basename, match2)
overrides = {('ui', 'forcemerge'): opts.get('tool', '')} overrides = {('ui', 'forcemerge'): opts.get('tool', '')}
with ui.configoverride(overrides, 'unshelve'): with ui.configoverride(overrides, 'unshelve'):
mergefiles(ui, repo, pctx, shelvectx) mergefiles(ui, repo, pctx, shelvectx)
restorebranch(ui, repo, branchtorestore) restorebranch(ui, repo, branchtorestore)
if not interactive or (interactive and files == filesinclude):
_forgetunknownfiles(repo, shelvectx, addedbefore) _forgetunknownfiles(repo, shelvectx, addedbefore)
pulkitUnsubmitted
Done

Can you explain why we are not processing this if files are present?

pulkit: Can you explain why we are not processing this if files are present?
navaneeth.sureshAuthorUnsubmitted
Done

okay. on unshelving with --files flag, we don't want to clear the shelvedstate unless all the files in the shelvectx is same as the files which are requested by the user. on unshelving without --files flag, we can clear the shelvedstate right away. that's why i have used this condition.

navaneeth.suresh: okay. on unshelving with `--files` flag, we don't want to clear the shelvedstate unless all the…
shelvedstate.clear(repo) shelvedstate.clear(repo)
_finishunshelve(repo, oldtiprev, tr, activebookmark) _finishunshelve(repo, oldtiprev, tr, activebookmark)
unshelvecleanup(ui, repo, basename, opts) unshelvecleanup(ui, repo, basename, opts)
finally: finally:
if tr: if tr:
tr.release() tr.release()
lockmod.release(lock) lockmod.release(lock)

tests/test-completion.t

serve: accesslog, daemon, daemon-postexec, errorlog, port, address, prefix, name, web-conf, webdir-conf, pid-file, stdio, cmdserver, templates, style, ipv6, certificate, print-url, subrepos serve: accesslog, daemon, daemon-postexec, errorlog, port, address, prefix, name, web-conf, webdir-conf, pid-file, stdio, cmdserver, templates, style, ipv6, certificate, print-url, subrepos
shelve: addremove, unknown, cleanup, date, delete, edit, keep, list, message, name, patch, interactive, stat, include, exclude shelve: addremove, unknown, cleanup, date, delete, edit, keep, list, message, name, patch, interactive, stat, include, exclude
status: all, modified, added, removed, deleted, clean, unknown, ignored, no-status, terse, copies, print0, rev, change, include, exclude, subrepos, template status: all, modified, added, removed, deleted, clean, unknown, ignored, no-status, terse, copies, print0, rev, change, include, exclude, subrepos, template
summary: remote summary: remote
tag: force, local, rev, remove, edit, message, date, user tag: force, local, rev, remove, edit, message, date, user
tags: template tags: template
tip: patch, git, style, template tip: patch, git, style, template
unbundle: update unbundle: update
unshelve: abort, continue, keep, name, tool, date unshelve: abort, continue, interactive, keep, name, tool, date
update: clean, check, merge, date, rev, tool update: clean, check, merge, date, rev, tool
verify: full verify: full
version: template version: template
$ hg init a $ hg init a
$ cd a $ cd a
$ echo fee > fee $ echo fee > fee
$ hg ci -q -Amfee $ hg ci -q -Amfee

tests/test-shelve.t

-- trying to pull in the shelve bits -- trying to pull in the shelve bits
-- unshelve should abort otherwise, it'll eat my second parent. -- unshelve should abort otherwise, it'll eat my second parent.
$ hg unshelve $ hg unshelve
abort: outstanding uncommitted merge abort: outstanding uncommitted merge
(use 'hg commit' or 'hg merge --abort') (use 'hg commit' or 'hg merge --abort')
[255] [255]
$ cd .. $ cd ..
-- unshelve --interactive
$ hg init a
$ cd a
$ echo > b
$ hg ci -Am b
adding b
$ echo > c
$ echo > d
$ hg add .
adding c
adding d
$ hg shelve
shelved as default
0 files updated, 0 files merged, 2 files removed, 0 files unresolved
$ echo > e
$ hg add e
$ hg ci -m e
$ hg shelve --patch
default (1s ago) changes to: b
diff --git a/c b/c
new file mode 100644
--- /dev/null
+++ b/c
@@ -0,0 +1,1 @@
+
diff --git a/d b/d
new file mode 100644
--- /dev/null
+++ b/d
@@ -0,0 +1,1 @@
+
$ hg unshelve -i<<EOF
> y
> n
> EOF
unshelving change 'default'
rebasing shelved changes
unshelve changes in file c (Yn)? y
unshelve changes in file d (Yn)? n
$ ls
b
c
e
-- shelve should not contain `c` now
pulkitUnsubmitted
Done

add a comment here specifying that shelve should not contain c now.

pulkit: add a comment here specifying that shelve should not contain `c` now.
$ hg shelve --patch
default (1s ago) changes to: b
diff --git a/d b/d
new file mode 100644
--- /dev/null
+++ b/d
@@ -0,0 +1,1 @@
+
$ hg unshelve
unshelving change 'default'
$ ls
b
c
d
e
$ hg shelve --list
pulkitUnsubmitted
Not Done

We should store information about --interacive in shelve state, which will help us to prevent passing -i here again.

pulkit: We should store information about `--interacive` in shelve state, which will help us to prevent…
navaneeth.sureshAuthorUnsubmitted
Done

We only pass -i if we want to do the unshelve interactively again. It's not mandatory to do that. After an interactive shelve, the stored remaining shelve is same as a normal shelve. We can unshelve it without the -i. So, I don't think we have to do that.

navaneeth.suresh: We only pass `-i` if we want to do the unshelve interactively again. It's not mandatory to do…
pulkitUnsubmitted
Not Done

Looking at the test case:

User wants to interactively unshelve, runs hg unshelve -i. They hit conflicts, resolve conflicts, and then run hg unshelve --continue.

Here, user intended to do an interactive unshelve, and having conflicts should not change what user wanted. Also this is similar to other commands. We preserve the flags which user passed and follow them when the operation is continued.

pulkit: Looking at the test case: User wants to interactively unshelve, runs `hg unshelve -i`. They…