This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6681

debugcommands: add support for extensions adding their own debug info
ClosedPublic

Authored by durin42 on Jul 23 2019, 3:40 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7f1df7019497: debugcommands: add support for extensions adding their own debug info
rHG0c0478b71595: debugcommands: add support for extensions adding their own debug info
Summary

We've had a couple of cases where it'd be handy at Google to add data
to hg debuginstall's output. We've kludged around that at various
times, but it seems reasonable to let extensions add their own data
here so extension maintainers can get useful extra data.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (5 lines)

Diff 16034

mercurial/debugcommands.py

except error.Abort as e: except error.Abort as e:
err = stringutil.forcebytestr(e) err = stringutil.forcebytestr(e)
problems += 1 problems += 1
fm.condwrite(username, 'username', _("checking username (%s)\n"), username) fm.condwrite(username, 'username', _("checking username (%s)\n"), username)
fm.condwrite(err, 'usernameerror', _("checking username...\n %s\n" fm.condwrite(err, 'usernameerror', _("checking username...\n %s\n"
" (specify a username in your configuration file)\n"), err) " (specify a username in your configuration file)\n"), err)
for name, mod in extensions.extensions():
handler = getattr(mod, 'debuginstall', None)
if handler is not None:
problems += handler(ui, fm)
fm.condwrite(not problems, '', fm.condwrite(not problems, '',
_("no problems detected\n")) _("no problems detected\n"))
if not problems: if not problems:
fm.data(problems=problems) fm.data(problems=problems)
fm.condwrite(problems, 'problems', fm.condwrite(problems, 'problems',
_("%d problems detected," _("%d problems detected,"
" please check your install!\n"), problems) " please check your install!\n"), problems)
fm.end() fm.end()