This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6683

unshelve: unify logic around creating an unshelve changeset
ClosedPublic

Authored by navaneeth.suresh on Jul 23 2019, 11:39 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc9114885c14b: unshelve: unify logic around creating an unshelve changeset
Summary

This is a follow-up patch to 5162753c4c14 on addressing reviews
on the commit. This unifies the logic around creating an unshelve
changeset.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Jul 24 2019, 4:52 AM

This patch does following things:

  1. unify logic around creating unshelvectx
  2. changes how date is set in iteractive mode
  3. handles stripping in interavtive mode
  4. compute a matcher only if it's required
  5. and a change around making basename madatory argument

Can we have them in separate patches?

navaneeth.suresh retitled this revision from unshelve: fixes on interactive mode to unshelve: unify logic around creating an unshelve changeset.Jul 24 2019, 8:39 AM
navaneeth.suresh edited the summary of this revision. (Show Details)
navaneeth.suresh updated this revision to Diff 16038.
navaneeth.suresh added a comment.Jul 24 2019, 8:56 AM
In D6683#97731, @pulkit wrote:

This patch does following things:

  1. unify logic around creating unshelvectx
  2. changes how date is set in iteractive mode
  3. handles stripping in interavtive mode
  4. compute a matcher only if it's required
  5. and a change around making basename madatory argument

Can we have them in separate patches?

Done.

pulkit added inline comments.Jul 26 2019, 10:37 AM
mercurial/shelve.py
812

How about:

Handles creation of unshelve commit and updating the shelve if it was partially unshelved.

If interactive is:

  * false: commit all the changes in working directory.
  * true: prompts user to select changes to unshelve and commit them. Update the shelve with remaining changes.

Returns the node of the new commit formed and a bool indicating whether the shelve was partially unshelved.
navaneeth.suresh added inline comments.Jul 26 2019, 11:24 AM
mercurial/shelve.py
812

Awesome! Amending that right away.

pulkit accepted this revision.Jul 29 2019, 5:43 AM
This revision is now accepted and ready to land.Jul 29 2019, 5:43 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (41 lines)

Diff 16038

mercurial/shelve.py

targetphase = phases.internal targetphase = phases.internal
if not phases.supportinternal(repo): if not phases.supportinternal(repo):
targetphase = phases.secret targetphase = phases.secret
overrides = {('phases', 'new-commit'): targetphase} overrides = {('phases', 'new-commit'): targetphase}
with repo.ui.configoverride(overrides, 'unshelve'): with repo.ui.configoverride(overrides, 'unshelve'):
with repo.dirstate.parentchange(): with repo.dirstate.parentchange():
repo.setparents(state.parents[0], nodemod.nullid) repo.setparents(state.parents[0], nodemod.nullid)
if not interactive: newnode, ispartialunshelve = _createunshelvectx(ui,
ispartialunshelve = False repo, shelvectx, basename, interactive, opts)
newnode = repo.commit(text=shelvectx.description(),
extra=shelvectx.extra(),
user=shelvectx.user(),
date=shelvectx.date())
else:
newnode, ispartialunshelve = _dounshelveinteractive(ui,
repo, shelvectx, basename, opts)
if newnode is None: if newnode is None:
# If it ended up being a no-op commit, then the normal # If it ended up being a no-op commit, then the normal
# merge state clean-up path doesn't happen, so do it # merge state clean-up path doesn't happen, so do it
# here. Fix issue5494 # here. Fix issue5494
merge.mergestate.clean(repo) merge.mergestate.clean(repo)
shelvectx = state.pendingctx shelvectx = state.pendingctx
msg = _('note: unshelved changes already existed ' msg = _('note: unshelved changes already existed '
if node is None: if node is None:
info = {'node': nodemod.hex(shelvectx.node())} info = {'node': nodemod.hex(shelvectx.node())}
shelvedfile(repo, basename, 'shelve').writeinfo(info) shelvedfile(repo, basename, 'shelve').writeinfo(info)
else: else:
shelvectx = repo[node] shelvectx = repo[node]
return repo, shelvectx return repo, shelvectx
def _dounshelveinteractive(ui, repo, shelvectx, basename, opts): def _createunshelvectx(ui, repo, shelvectx, basename, interactive, opts):
"""The user might want to unshelve certain changes only from the stored """Creates a commit ctx to unshelve interactively or non-interactively.
shelve. So, we would create two commits. One with requested changes to The user might want to unshelve certain changes only from the stored
unshelve at that time and the latter is shelved for future. shelve in interactive. So, we would create two commits. One with requested
changes to unshelve at that time and the latter is shelved for future.
Here, we return both the newnode which is created interactively and a
bool to know whether the shelve is partly done or completely done.
pulkitUnsubmitted
Not Done

How about:

Handles creation of unshelve commit and updating the shelve if it was partially unshelved.

If interactive is:

  * false: commit all the changes in working directory.
  * true: prompts user to select changes to unshelve and commit them. Update the shelve with remaining changes.

Returns the node of the new commit formed and a bool indicating whether the shelve was partially unshelved.
pulkit: How about: ``` Handles creation of unshelve commit and updating the shelve if it was partially…
navaneeth.sureshAuthorUnsubmitted
Done

Awesome! Amending that right away.

navaneeth.suresh: Awesome! Amending that right away.
""" """
opts['message'] = shelvectx.description() opts['message'] = shelvectx.description()
opts['interactive-unshelve'] = True opts['interactive-unshelve'] = True
pats = [] pats = []
if not interactive:
newnode = repo.commit(text=shelvectx.description(),
extra=shelvectx.extra(),
user=shelvectx.user(),
date=shelvectx.date())
return newnode, False
commitfunc = getcommitfunc(shelvectx.extra(), interactive=True, commitfunc = getcommitfunc(shelvectx.extra(), interactive=True,
editor=True) editor=True)
newnode = cmdutil.dorecord(ui, repo, commitfunc, None, False, newnode = cmdutil.dorecord(ui, repo, commitfunc, None, False,
cmdutil.recordfilter, *pats, cmdutil.recordfilter, *pats,
**pycompat.strkwargs(opts)) **pycompat.strkwargs(opts))
snode = repo.commit(text=shelvectx.description(), snode = repo.commit(text=shelvectx.description(),
extra=shelvectx.extra(), extra=shelvectx.extra(),
user=shelvectx.user(), user=shelvectx.user(),
branchtorestore, opts.get('keep'), activebookmark, branchtorestore, opts.get('keep'), activebookmark,
interactive) interactive)
raise error.InterventionRequired( raise error.InterventionRequired(
_("unresolved conflicts (see 'hg resolve', then " _("unresolved conflicts (see 'hg resolve', then "
"'hg unshelve --continue')")) "'hg unshelve --continue')"))
with repo.dirstate.parentchange(): with repo.dirstate.parentchange():
repo.setparents(tmpwctx.node(), nodemod.nullid) repo.setparents(tmpwctx.node(), nodemod.nullid)
if not interactive: newnode, ispartialunshelve = _createunshelvectx(ui, repo,
ispartialunshelve = False shelvectx, basename, interactive, opts)
newnode = repo.commit(text=shelvectx.description(),
extra=shelvectx.extra(),
user=shelvectx.user(),
date=shelvectx.date())
else:
newnode, ispartialunshelve = _dounshelveinteractive(ui, repo,
shelvectx, basename, opts)
if newnode is None: if newnode is None:
# If it ended up being a no-op commit, then the normal # If it ended up being a no-op commit, then the normal
# merge state clean-up path doesn't happen, so do it # merge state clean-up path doesn't happen, so do it
# here. Fix issue5494 # here. Fix issue5494
merge.mergestate.clean(repo) merge.mergestate.clean(repo)
shelvectx = tmpwctx shelvectx = tmpwctx
msg = _('note: unshelved changes already existed ' msg = _('note: unshelved changes already existed '