This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6740

tests: add test to demonstrate issue6159
ClosedPublic

Authored by navaneeth.suresh on Aug 17 2019, 5:28 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGcf9dbc7377de: tests: add test to demonstrate issue6159

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit added a subscriber: pulkit.Aug 19 2019, 11:16 AM
pulkit added inline comments.
tests/test-bookmarks-pushpull.t
1344

--config phases.new-commit=secret can be used here instead to create a secret commit.

1371

we should cd to issue6519remote here right?

1381

No need for this.

navaneeth.suresh marked 3 inline comments as done.Aug 20 2019, 7:53 AM
navaneeth.suresh updated this revision to Diff 16266.
navaneeth.suresh added a comment.Aug 20 2019, 8:22 AM

@pulkit Now I'm unable to reproduce the test result given in the bug report. It seems like the remote repo recognizes the secret changeset cf489fd8a374.

navaneeth.suresh added a comment.Aug 23 2019, 3:06 PM

I'm able to reproduce the tests now. The case b2-binary can reproduce the test results.

pulkit accepted this revision.Aug 23 2019, 7:08 PM
This revision is now accepted and ready to land.Aug 23 2019, 7:08 PM
navaneeth.suresh added a commit: rHGcf9dbc7377de: tests: add test to demonstrate issue6159.Aug 25 2019, 12:26 PM
Closed by commit rHGcf9dbc7377de: tests: add test to demonstrate issue6159 (authored by navaneeth.suresh). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-bookmarks-pushpull.t (88 lines)

Diff 16257

tests/test-bookmarks-pushpull.t

$ hg -R client push $ hg -R client push
pushing to ssh://user@dummy/server pushing to ssh://user@dummy/server
searching for changes searching for changes
no changes found no changes found
remote: prepushkey.no-bm-move hook exited with status 1 remote: prepushkey.no-bm-move hook exited with status 1
abort: push failed on remote abort: push failed on remote
[255] [255]
#endif #endif
-- test for stop pushing bookmarks pointing to secret changesets
Set up a "remote" repo
$ hg init issue6159remote
$ cd issue6159remote
$ echo a > a
$ hg add a
$ hg commit -m_
$ hg bookmark foo
$ cd ..
Clone a local repo
$ hg clone -q issue6159remote issue6159local
$ cd issue6159local
$ hg up -qr foo
$ echo b > b
Move the bookmark "foo" to point at a secret changeset
$ hg commit -qAm_
pulkitUnsubmitted
Done

--config phases.new-commit=secret can be used here instead to create a secret commit.

pulkit: `--config phases.new-commit=secret` can be used here instead to create a secret commit.
$ hg phase -s -f
$ hg log -r . --template '{node}'
cf489fd8a374cab73c2dc19e899bde6fe3a43f8f (no-eol)
Pushing the bookmark "foo" now fails as it contains a secret changeset
#if b2-pushkey
$ hg push -r foo
pushing to $TESTTMP/issue6159remote
searching for changes
no changes found (ignored 1 secret changesets)
abort: updating bookmark foo failed!
[255]
#endif
#if b2-binary
$ hg push -r foo
pushing to $TESTTMP/issue6159remote
searching for changes
no changes found (ignored 1 secret changesets)
updating bookmark foo
[1]
#endif
Now the "remote" repo contains a bookmark pointing to a nonexistent revision
#if b2-pushkey
$ cd ../a
pulkitUnsubmitted
Done

we should cd to issue6519remote here right?

pulkit: we should cd to `issue6519remote` here right?
$ hg bookmark
@ 1:0d2164f0ce0d
@1 2:9b140be10808
* X 1:0d2164f0ce0d
X@1 2:9b140be10808
Y 5:c922c0139ca0
Z 1:0d2164f0ce0d
foo -1:000000000000
foobar 2:9b140be10808
$ cat .hg/bookmarks
pulkitUnsubmitted
Done

No need for this.

pulkit: No need for this.
0d2164f0ce0d8f1d6f94351eba04b794909be66c @
9b140be1080824d768c5a4691a564088eede71f9 @1
0d2164f0ce0d8f1d6f94351eba04b794909be66c X
9b140be1080824d768c5a4691a564088eede71f9 X@1
c922c0139ca03858f655e4a2af4dd02796a63969 Y
0d2164f0ce0d8f1d6f94351eba04b794909be66c Z
0000000000000000000000000000000000000000 foo
9b140be1080824d768c5a4691a564088eede71f9 foobar
#endif
#if b2-binary
$ cd ../a
$ hg bookmark
@ 1:0d2164f0ce0d
@1 2:9b140be10808
* X 1:0d2164f0ce0d
X@1 2:9b140be10808
Y 5:c922c0139ca0
Z 1:0d2164f0ce0d
foo -1:000000000000
foobar 2:9b140be10808
$ cat .hg/bookmarks
0d2164f0ce0d8f1d6f94351eba04b794909be66c @
9b140be1080824d768c5a4691a564088eede71f9 @1
0d2164f0ce0d8f1d6f94351eba04b794909be66c X
9b140be1080824d768c5a4691a564088eede71f9 X@1
c922c0139ca03858f655e4a2af4dd02796a63969 Y
0d2164f0ce0d8f1d6f94351eba04b794909be66c Z
0000000000000000000000000000000000000000 foo
9b140be1080824d768c5a4691a564088eede71f9 foobar
#endif