This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6779

statprof: use context manager when reading source from file
ClosedPublic

Authored by martinvonz on Aug 31 2019, 1:35 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc085cb134b9e: statprof: use context manager when reading source from file

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/statprof.py (14 lines)

Diff 16344

mercurial/statprof.py

except KeyError: except KeyError:
v = cls(path, lineno, function) v = cls(path, lineno, function)
cls.cache[k] = v cls.cache[k] = v
return v return v
def getsource(self, length): def getsource(self, length):
if self.source is None: if self.source is None:
lineno = self.lineno - 1 lineno = self.lineno - 1
fp = None
try: try:
fp = open(self.path, 'rb') with open(self.path, 'rb') as fp:
for i, line in enumerate(fp): for i, line in enumerate(fp):
if i == lineno: if i == lineno:
self.source = line.strip() self.source = line.strip()
break break
except: except:
pass pass
finally:
if fp:
fp.close()
if self.source is None: if self.source is None:
self.source = '' self.source = ''
source = self.source source = self.source
if len(source) > length: if len(source) > length:
source = source[:(length - 3)] + "..." source = source[:(length - 3)] + "..."
return source return source