This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6794

repair: extract a helper for generating all manifest revlogs
ClosedPublic

Authored by martinvonz on Sep 7 2019, 2:37 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6d0fdba635e5: repair: extract a helper for generating all manifest revlogs
Summary

We'll need to walk the manifest revlogs also to figure out which
manifests have linkrevs out of order (for fixing the bug shown in the
previous patch).

By the way, perhaps it would be more efficient in many cases to find
only the relevant directory manifest revlogs based on the files
instead of walking the entire store, but that can be changed later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 16463

mercurial/repair.py

if callback is None: if callback is None:
callback = stripcallback(ui, repo, backup=backup, topic=topic) callback = stripcallback(ui, repo, backup=backup, topic=topic)
tr.addpostclose('\xffstrip', callback) tr.addpostclose('\xffstrip', callback)
if topic: if topic:
callback.topic = topic callback.topic = topic
callback.addnodes(nodelist) callback.addnodes(nodelist)
def stripmanifest(repo, striprev, tr, files): def stripmanifest(repo, striprev, tr, files):
revlog = repo.manifestlog.getstorage(b'') for revlog in manifestrevlogs(repo):
revlog.strip(striprev, tr) revlog.strip(striprev, tr)
striptrees(repo, tr, striprev, files)
def striptrees(repo, tr, striprev, files): def manifestrevlogs(repo):
yield repo.manifestlog.getstorage(b'')
if 'treemanifest' in repo.requirements: if 'treemanifest' in repo.requirements:
# This logic is safe if treemanifest isn't enabled, but also # This logic is safe if treemanifest isn't enabled, but also
# pointless, so we skip it if treemanifest isn't enabled. # pointless, so we skip it if treemanifest isn't enabled.
for unencoded, encoded, size in repo.store.datafiles(): for unencoded, encoded, size in repo.store.datafiles():
if (unencoded.startswith('meta/') and if (unencoded.startswith('meta/') and
unencoded.endswith('00manifest.i')): unencoded.endswith('00manifest.i')):
dir = unencoded[5:-12] dir = unencoded[5:-12]
repo.manifestlog.getstorage(dir).strip(striprev, tr) yield repo.manifestlog.getstorage(dir)
def rebuildfncache(ui, repo): def rebuildfncache(ui, repo):
"""Rebuilds the fncache file from repo history. """Rebuilds the fncache file from repo history.
Missing entries will be added. Extra entries will be removed. Missing entries will be added. Extra entries will be removed.
""" """
repo = repo.unfiltered() repo = repo.unfiltered()