Page MenuHomePhabricator

py3: drop incorrect fsencode(findexe(...)) in procutil
ClosedPublic

Authored by martinvonz on Sep 7 2019, 1:05 PM.

Details

Summary

I recently added the bad call, thinking that findexe() was a standard
library function returning a string result, but it's actually our own
function returning bytes. Thanks to Yuya for noticing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 7 2019, 1:05 PM
indygreg accepted this revision.Sep 7 2019, 1:21 PM
This revision is now accepted and ready to land.Sep 7 2019, 1:21 PM
This revision was automatically updated to reflect the committed changes.