This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6919

interfaces: use triple quotes for Attribute value
ClosedPublic

Authored by indygreg on Sep 29 2019, 3:22 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5f8b6617e962: interfaces: use triple quotes for Attribute value
Summary

Otherwise the source transformer converts it to bytes and
test-check-interfaces.py complains on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 29 2019, 3:22 PM
pulkit accepted this revision.Sep 30 2019, 8:16 AM
This revision is now accepted and ready to land.Sep 30 2019, 8:16 AM
indygreg added a commit: rHG5f8b6617e962: interfaces: use triple quotes for Attribute value.Sep 30 2019, 8:49 AM
Closed by commit rHG5f8b6617e962: interfaces: use triple quotes for Attribute value (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/interfaces/dirstate.py (6 lines)

Diff 16701

mercurial/interfaces/dirstate.py

opener is an open()-like callable that can be used to open the opener is an open()-like callable that can be used to open the
dirstate file; root is the root of the directory tracked by dirstate file; root is the root of the directory tracked by
the dirstate. the dirstate.
''' '''
# TODO: all these private methods and attributes should be made # TODO: all these private methods and attributes should be made
# public or removed from the interface. # public or removed from the interface.
_ignore = interfaceutil.Attribute('Matcher for ignored files.') _ignore = interfaceutil.Attribute("""Matcher for ignored files.""")
def _ignorefiles(): def _ignorefiles():
"""Return a list of files containing patterns to ignore.""" """Return a list of files containing patterns to ignore."""
def _ignorefileandline(f): def _ignorefileandline(f):
"Given a file `f`, return the ignore file and line that ignores it." "Given a file `f`, return the ignore file and line that ignores it."
_checklink = interfaceutil.Attribute('Callable for checking symlinks.') _checklink = interfaceutil.Attribute("""Callable for checking symlinks.""")
_checkexec = interfaceutil.Attribute('Callable for checking exec bits.') _checkexec = interfaceutil.Attribute("""Callable for checking exec bits.""")
@contextlib.contextmanager @contextlib.contextmanager
def parentchange(): def parentchange():
'''Context manager for handling dirstate parents. '''Context manager for handling dirstate parents.
If an exception occurs in the scope of the context manager, If an exception occurs in the scope of the context manager,
the incoherent dirstate won't be written when wlock is the incoherent dirstate won't be written when wlock is
released. released.