( )⚙ D6938 changegroup: use positive logic for treemanifest changegroup3 logic

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6938

changegroup: use positive logic for treemanifest changegroup3 logic
ClosedPublic

Authored by marmoute on Oct 1 2019, 12:07 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG4bbc9569e722: changegroup: use positive logic for treemanifest changegroup3 logic
Summary

We are about to add more cases, in that context, it is simpler to avoid double
negative.

En addition, We document the situation for the next soul.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (16 lines)

Diff 16865

mercurial/changegroup.py

# cg2 adds support for exchanging generaldelta # cg2 adds support for exchanging generaldelta
'02': (_makecg2packer, cg2unpacker), '02': (_makecg2packer, cg2unpacker),
# cg3 adds support for exchanging revlog flags and treemanifests # cg3 adds support for exchanging revlog flags and treemanifests
'03': (_makecg3packer, cg3unpacker), '03': (_makecg3packer, cg3unpacker),
} }
def allsupportedversions(repo): def allsupportedversions(repo):
versions = set(_packermap.keys()) versions = set(_packermap.keys())
if not (repo.ui.configbool('experimental', 'changegroup3') or needv03 = False
if (repo.ui.configbool('experimental', 'changegroup3') or
repo.ui.configbool('experimental', 'treemanifest') or repo.ui.configbool('experimental', 'treemanifest') or
'treemanifest' in repo.requirements): 'treemanifest' in repo.requirements):
# we keep version 03 because we need to to exchange treemanifest data
#
# we also keep vresion 01 and 02, because it is possible for repo to
# contains both normal and tree manifest at the same time. so using
# older version to pull data is viable
#
# (or even to push subset of history)
needv03 = True
if not needv03:
versions.discard('03') versions.discard('03')
return versions return versions
# Changegroup versions that can be applied to the repo # Changegroup versions that can be applied to the repo
def supportedincomingversions(repo): def supportedincomingversions(repo):
return allsupportedversions(repo) return allsupportedversions(repo)
# Changegroup versions that can be created from the repo # Changegroup versions that can be created from the repo