This is an archive of the discontinued Mercurial Phabricator instance.

hghave: document format for version feature checks as <name><vers>, no dots
ClosedPublic

Authored by spectral on Oct 8 2019, 2:17 PM.

Details

Summary

I had a bit of a difficult time when attempting to fix a use of py-38 when
trying to figure out what the correct way of specifying the feature was. By
having the strings 'py-3*' and 'py3.8' in the hghave.checkvers docstring, I
would have had a much easier time of it instead of having to trace exactly what
was happening here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Oct 8 2019, 2:17 PM
pulkit accepted this revision.Oct 8 2019, 3:28 PM
This revision is now accepted and ready to land.Oct 8 2019, 3:28 PM
pulkit added a comment.Oct 8 2019, 3:44 PM

Looks like D7016 fixed it. +1 to the docs you have added, if you rebase and resend with the commit message updated, I will be happy to push it.

spectral retitled this revision from tests: fix test-archive to specify feature as py38, not py-38 to hghave: document format for version feature checks as <name><vers>, no dots.Oct 8 2019, 3:59 PM
spectral edited the summary of this revision. (Show Details)
spectral updated this revision to Diff 16974.