This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7078

automation: capture additional exception when formatting
ClosedPublic

Authored by indygreg on Oct 12 2019, 4:56 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6a350194de7f: automation: capture additional exception when formatting
Summary

I started encountering this for some reason.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 12 2019, 4:56 PM
pulkit accepted this revision.Oct 14 2019, 8:32 AM
This revision is now accepted and ready to land.Oct 14 2019, 8:32 AM

Revision Contents
Changeset List

Diff 17119

contrib/automation/hgautomation/winrm.py

def format_object(o): def format_object(o):
if isinstance(o, str): if isinstance(o, str):
return o return o
try: try:
o = str(o) o = str(o)
except TypeError: except (AttributeError, TypeError):
o = pprint.pformat(o.extended_properties) o = pprint.pformat(o.extended_properties)
return o return o
def run_powershell(client, script): def run_powershell(client, script):
with RunspacePool(client.wsman) as pool: with RunspacePool(client.wsman) as pool:
ps = PowerShell(pool) ps = PowerShell(pool)