This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7080

hghave: use a native string to invoke the `black` command
ClosedPublic

Authored by mharbison72 on Oct 12 2019, 10:31 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG138ac8cbce60: hghave: use a native string to invoke the `black` command
Summary

Windows can't create a process based on bytes. Apparently only the output test
in matchoutput wants bytes.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mharbison72 created this revision.Oct 12 2019, 10:31 PM
indygreg accepted this revision.Oct 13 2019, 1:15 AM
This revision is now accepted and ready to land.Oct 13 2019, 1:15 AM

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (4 lines)

Diff 17122

tests/hghave.py

# 24 release) # 24 release)
return matchoutput('emacs --version', b'GNU Emacs 2(4.4|4.5|5|6|7|8|9)') return matchoutput('emacs --version', b'GNU Emacs 2(4.4|4.5|5|6|7|8|9)')
# @check('black', 'the black formatter for python') # @check('black', 'the black formatter for python')
@check('grey', 'grey, the fork of the black formatter for python') @check('grey', 'grey, the fork of the black formatter for python')
def has_black(): def has_black():
# use that to actual black as soon as possible # use that to actual black as soon as possible
# blackcmd = b'black --version' # blackcmd = 'black --version'
blackcmd = b'python3 $RUNTESTDIR/../contrib/grey.py --version' blackcmd = 'python3 $RUNTESTDIR/../contrib/grey.py --version'
# version_regex = b'black, version \d' # version_regex = b'black, version \d'
version_regex = b'grey.py, version \d' version_regex = b'grey.py, version \d'
return matchoutput(blackcmd, version_regex) return matchoutput(blackcmd, version_regex)