This is an archive of the discontinued Mercurial Phabricator instance.

Differential D709

bundle2: move part processing to a separate function
ClosedPublic

Authored by durham on Sep 13 2017, 8:39 PM.

Details

Reviewers
krbullock
Group Reviewers
hg-reviewers
Commits
rHGf010097c885c: bundle2: move part processing to a separate function
Summary

Now that the part processing loop is tiny, let's move it to a separate function.
This will allow extensions to completely replace the part processing logic,
without having to replace the overall bundle processing logic or the stream
maintenance logic.

This will be useful for the infinitepush extension, so it can completely take
over receiving a bundle and rerouting it to a side store. This will also make it
easier to upstream the infinitepush functionality later.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durham created this revision.Sep 13 2017, 8:39 PM
durham updated this revision to Diff 1821.Sep 14 2017, 1:21 PM
krbullock accepted this revision.Sep 18 2017, 4:39 PM
This revision is now accepted and ready to land.Sep 18 2017, 4:39 PM
Closed by commit rHGf010097c885c: bundle2: move part processing to a separate function (authored by durham). · Explain WhySep 18 2017, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (7 lines)

Diff 1805

mercurial/bundle2.py

msg.append(' %i params' % len(unbundler.params)) msg.append(' %i params' % len(unbundler.params))
if op._gettransaction is None or op._gettransaction is _notransaction: if op._gettransaction is None or op._gettransaction is _notransaction:
msg.append(' no-transaction') msg.append(' no-transaction')
else: else:
msg.append(' with-transaction') msg.append(' with-transaction')
msg.append('\n') msg.append('\n')
repo.ui.debug(''.join(msg)) repo.ui.debug(''.join(msg))
processparts(repo, op, unbundler)
return op
def processparts(repo, op, unbundler):
with partiterator(repo, op, unbundler) as parts: with partiterator(repo, op, unbundler) as parts:
for part in parts: for part in parts:
_processpart(op, part) _processpart(op, part)
return op
def _processchangegroup(op, cg, tr, source, url, **kwargs): def _processchangegroup(op, cg, tr, source, url, **kwargs):
ret = cg.apply(op.repo, tr, source, url, **kwargs) ret = cg.apply(op.repo, tr, source, url, **kwargs)
op.records.add('changegroup', { op.records.add('changegroup', {
'return': ret, 'return': ret,
}) })
return ret return ret
def _gethandler(op, part): def _gethandler(op, part):