( )⚙ D7109 dirstate: add some traces on listdir calls

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7109

dirstate: add some traces on listdir calls
ClosedPublic

Authored by durin42 on Oct 15 2019, 11:22 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6fcdcea2b03a: dirstate: add some traces on listdir calls
rHGfbc1c6bb6c52: dirstate: add some traces on listdir calls
rHGbc5c4919a1a0: dirstate: add some traces on listdir calls
Summary

I'm starting to spend some time trying to make hg status do less work, and
knowing what's happening in here and what's expensive is an important start.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (7 lines)

Diff 17179

mercurial/dirstate.py

import contextlib import contextlib
import errno import errno
import os import os
import stat import stat
from .i18n import _ from .i18n import _
from .node import nullid from .node import nullid
from .pycompat import delattr from .pycompat import delattr
from hgdemandimport import tracing
from . import ( from . import (
encoding, encoding,
error, error,
match as matchmod, match as matchmod,
pathutil, pathutil,
policy, policy,
pycompat, pycompat,
scmutil, scmutil,
skipstep3 = skipstep3 and not (work or dirsnotfound) skipstep3 = skipstep3 and not (work or dirsnotfound)
work = [d for d in work if not dirignore(d[0])] work = [d for d in work if not dirignore(d[0])]
# step 2: visit subdirectories # step 2: visit subdirectories
def traverse(work, alreadynormed): def traverse(work, alreadynormed):
wadd = work.append wadd = work.append
while work: while work:
tracing.counter('dirstate.walk work', len(work))
nd = work.pop() nd = work.pop()
visitentries = match.visitchildrenset(nd) visitentries = match.visitchildrenset(nd)
if not visitentries: if not visitentries:
continue continue
if visitentries == b'this' or visitentries == b'all': if visitentries == b'this' or visitentries == b'all':
visitentries = None visitentries = None
skip = None skip = None
if nd != b'': if nd != b'':
skip = b'.hg' skip = b'.hg'
try: try:
with tracing.log('dirstate.walk.traverse listdir %s', nd):
entries = listdir(join(nd), stat=True, skip=skip) entries = listdir(join(nd), stat=True, skip=skip)
except OSError as inst: except OSError as inst:
if inst.errno in (errno.EACCES, errno.ENOENT): if inst.errno in (errno.EACCES, errno.ENOENT):
match.bad( match.bad(
self.pathto(nd), encoding.strtolocal(inst.strerror) self.pathto(nd), encoding.strtolocal(inst.strerror)
) )
continue continue
raise raise
for f, kind, st in entries: for f, kind, st in entries: