This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7150

dirstate: respect request to not list unknown/ignored/clean files (API)
ClosedPublic

Authored by martinvonz on Oct 23 2019, 2:49 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGdd773340a085: dirstate: respect request to not list unknown/ignored/clean files (API)
Summary

Unknown files that are explicitly mentioned by the matcher are
returned even if the caller said unknown=False (and it seems the same
is done for ignored files). That seems pretty surprising. Let's make
the interface less surprising by respecting the caller's request.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 23 2019, 2:49 AM
martinvonz added a comment.Nov 12 2019, 2:11 PM

Ping on this. It seems like a simple and harmless patch.

martinvonz updated this revision to Diff 18049.Nov 12 2019, 5:57 PM
pulkit accepted this revision.Nov 13 2019, 8:16 AM
This revision is now accepted and ready to land.Nov 13 2019, 8:16 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (9 lines)

Diff 18054

mercurial/dirstate.py

removed=removed, removed=removed,
deleted=deleted, deleted=deleted,
unknown=unknown, unknown=unknown,
ignored=ignored, ignored=ignored,
clean=clean, clean=clean,
) )
return (lookup, status) return (lookup, status)
def noop(f):
pass
dcontains = dmap.__contains__ dcontains = dmap.__contains__
dget = dmap.__getitem__ dget = dmap.__getitem__
ladd = lookup.append # aka "unsure" ladd = lookup.append # aka "unsure"
madd = modified.append madd = modified.append
aadd = added.append aadd = added.append
uadd = unknown.append uadd = unknown.append if listunknown else noop
iadd = ignored.append iadd = ignored.append if listignored else noop
radd = removed.append radd = removed.append
dadd = deleted.append dadd = deleted.append
cadd = clean.append cadd = clean.append if listclean else noop
mexact = match.exact mexact = match.exact
dirignore = self._dirignore dirignore = self._dirignore
checkexec = self._checkexec checkexec = self._checkexec
copymap = self._map.copymap copymap = self._map.copymap
lastnormaltime = self._lastnormaltime lastnormaltime = self._lastnormaltime
# We need to do full walks when either # We need to do full walks when either
# - we're listing all clean files, or # - we're listing all clean files, or