This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: respect request to not list unknown/ignored/clean files (API)
ClosedPublic

Authored by martinvonz on Oct 23 2019, 2:49 AM.

Details

Summary

Unknown files that are explicitly mentioned by the matcher are
returned even if the caller said unknown=False (and it seems the same
is done for ignored files). That seems pretty surprising. Let's make
the interface less surprising by respecting the caller's request.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Oct 23 2019, 2:49 AM

Ping on this. It seems like a simple and harmless patch.

martinvonz updated this revision to Diff 18049.Nov 12 2019, 5:57 PM
pulkit accepted this revision.Nov 13 2019, 8:16 AM
This revision is now accepted and ready to land.Nov 13 2019, 8:16 AM