( )⚙ D7184 py3: avoid another b''.format() in chistedit

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7184

py3: avoid another b''.format() in chistedit
ClosedPublic

Authored by martinvonz on Oct 31 2019, 6:22 PM.

Details

Reviewers
durin42
indygreg
Group Reviewers
hg-reviewers
Commits
rHG85ab79bc7dab: py3: avoid another b''.format() in chistedit
rHGef0730a0d673: py3: avoid another b''.format() in chistedit
rHG45ec06859354: py3: avoid another b''.format() in chistedit
Summary

Now you'll get a different traceback if you try to confirm you
histedit plan.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 17439

hgext/histedit.py

return E_LINEUP return E_LINEUP
def makecommands(rules): def makecommands(rules):
"""Returns a list of commands consumable by histedit --commands based on """Returns a list of commands consumable by histedit --commands based on
our list of rules""" our list of rules"""
commands = [] commands = []
for rules in rules: for rules in rules:
commands.append(b"{0} {1}\n".format(rules.action, rules.ctx)) commands.append(b'%s %s\n' % (rules.action, rules.ctx))
return commands return commands
def addln(win, y, x, line, color=None): def addln(win, y, x, line, color=None):
"""Add a line to the given window left padding but 100% filled with """Add a line to the given window left padding but 100% filled with
whitespace characters, so that the color appears on the whole line""" whitespace characters, so that the color appears on the whole line"""
maxy, maxx = win.getmaxyx() maxy, maxx = win.getmaxyx()
length = maxx - 1 - x length = maxx - 1 - x