This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7220

contrib: require Python 3.7 for byteify-strings.py
ClosedPublic

Authored by Kwan on Nov 4 2019, 2:21 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG09234eeae206: contrib: require Python 3.7 for byteify-strings.py
Summary

bb509f39d387 made an error, it's actually 3.7 that introduced token.COMMENT.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Nov 4 2019, 2:21 PM
Kwan added a commit: rHG09234eeae206: contrib: require Python 3.7 for byteify-strings.py.Nov 4 2019, 5:08 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG09234eeae206: contrib: require Python 3.7 for byteify-strings.py (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 17540

contrib/byteify-strings.py

process(fin, fout, opts) process(fin, fout, opts)
else: else:
with open(fname, 'rb') as fin: with open(fname, 'rb') as fin:
fout = sys.stdout.buffer fout = sys.stdout.buffer
process(fin, fout, opts) process(fin, fout, opts)
if __name__ == '__main__': if __name__ == '__main__':
if sys.version_info[0:2] < (3, 6): if sys.version_info[0:2] < (3, 7):
print('This script must be run under Python 3.6+') print('This script must be run under Python 3.7+')
sys.exit(3) sys.exit(3)
main() main()

tests/test-byteify-strings.t

#require py36 #require py37
$ byteify_strings () { $ byteify_strings () {
> $PYTHON "$TESTDIR/../contrib/byteify-strings.py" "$@" > $PYTHON "$TESTDIR/../contrib/byteify-strings.py" "$@"
> } > }
Test version Test version
$ byteify_strings --version $ byteify_strings --version