This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7226

tests: write out file using bytes I/O
ClosedPublic

Authored by indygreg on Nov 4 2019, 11:57 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe7eb67eab53f: tests: write out file using bytes I/O
Summary

The encoding of sys.stdout varies between Python versions. So
using a one-liner to write a file from a Unicode string is not
deterministic.

This commit writes out the file using bytes I/O to ensure we
have exactly the bytes we want in the file.

This change fixes a test failure in Python 3.5/3.6.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 4 2019, 11:58 PM
pulkit accepted this revision.Nov 5 2019, 4:17 AM
This revision is now accepted and ready to land.Nov 5 2019, 4:17 AM
indygreg added a commit: rHGe7eb67eab53f: tests: write out file using bytes I/O.Nov 5 2019, 11:04 AM
Closed by commit rHGe7eb67eab53f: tests: write out file using bytes I/O (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-highlight.t (4 lines)

Diff 17557

tests/test-highlight.t

<span id="l11"> def sieve(ns):</span><a href="#l11"></a> <span id="l11"> def sieve(ns):</span><a href="#l11"></a>
errors encountered errors encountered
$ cat errors.log $ cat errors.log
$ cd .. $ cd ..
$ hg init eucjp $ hg init eucjp
$ cd eucjp $ cd eucjp
$ "$PYTHON" -c 'print("\265\376")' >> eucjp.txt # Japanese kanji "Kyo" >>> with open('eucjp.txt', 'wb') as fh:
... # Japanese kanji "Kyo"
... fh.write(u'\265\376'.encode('utf-8')) and None
$ hg ci -Ama $ hg ci -Ama
adding eucjp.txt adding eucjp.txt
$ hgserveget () { $ hgserveget () {
> killdaemons.py > killdaemons.py
> echo % HGENCODING="$1" hg serve > echo % HGENCODING="$1" hg serve
> HGENCODING="$1" hg serve -p $HGPORT -d -n test --pid-file=hg.pid -E errors.log > HGENCODING="$1" hg serve -p $HGPORT -d -n test --pid-file=hg.pid -E errors.log
> cat hg.pid >> $DAEMON_PIDS > cat hg.pid >> $DAEMON_PIDS
> >