This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7227

localrepo: use str for lookup in vars()
ClosedPublic

Authored by indygreg on Nov 5 2019, 12:18 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa0916e8819f6: localrepo: use str for lookup in vars()
Summary

vars() returns a dict of str. So always use a native str for
the key lookup.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 17555

mercurial/localrepo.py

# cache stat computed in (1). As a result at locking time: # cache stat computed in (1). As a result at locking time:
# * if the changelog did not changed since (1) -> we can reuse the data # * if the changelog did not changed since (1) -> we can reuse the data
# * otherwise -> the bookmarks get refreshed. # * otherwise -> the bookmarks get refreshed.
self._refreshchangelog() self._refreshchangelog()
return bookmarks.bmstore(self) return bookmarks.bmstore(self)
def _refreshchangelog(self): def _refreshchangelog(self):
"""make sure the in memory changelog match the on-disk one""" """make sure the in memory changelog match the on-disk one"""
if b'changelog' in vars(self) and self.currenttransaction() is None: if 'changelog' in vars(self) and self.currenttransaction() is None:
del self.changelog del self.changelog
@property @property
def _activebookmark(self): def _activebookmark(self):
return self._bookmarks.active return self._bookmarks.active
# _phasesets depend on changelog. what we need is to call # _phasesets depend on changelog. what we need is to call
# _phasecache.invalidate() if '00changelog.i' was changed, but it # _phasecache.invalidate() if '00changelog.i' was changed, but it