This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7232

tests: fix a few `(no-windows !)` conditionals that are really `(symlink !)`
ClosedPublic

Authored by mharbison72 on Nov 5 2019, 6:35 PM.

Download Raw Diff

Details

Reviewers

indygreg

Group Reviewers

hg-reviewers

Commits

rHG0a0bad6d7ac0: tests: fix a few `(no-windows !)` conditionals that are really `(symlink !)`

Summary

The CI for py3 is assuming that symlinks are possible (they are when running as
Administrator or when Developer Mode is enabled), and these popped up.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

mharbison72 created this revision.Nov 5 2019, 6:35 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptNov 5 2019, 6:35 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

mharbison72 added a child revision: D7233: hghave: disallow symlinks on Windows.Nov 5 2019, 6:35 PM

indygreg accepted this revision.Nov 5 2019, 10:23 PM

This revision is now accepted and ready to land.Nov 5 2019, 10:23 PM

mharbison72 added a commit: rHG0a0bad6d7ac0: tests: fix a few `(no-windows !)` conditionals that are really `(symlink !)`.Nov 5 2019, 10:36 PM

Closed by commit rHG0a0bad6d7ac0: tests: fix a few `(no-windows !)` conditionals that are really `(symlink !)` (authored by mharbison72). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-fileset.t (8 lines)

Commit	Parents	Author	Summary	Date
e528ec15184b	93aeebc90ff9	Matt Harbison		Nov 5 2019, 6:25 PM

	Status	Author	Revision
	Closed	mharbison72	D7233 hghave: disallow symlinks on Windows
	Closed	mharbison72	D7232 tests: fix a few `(no-windows !)` conditionals that are really `(symlink !)`

Diff 17561

tests/test-fileset.t

	A a1			A a1
	A a2			A a2
	A b1			A b1
	A b2			A b2
	$ hg status --change 1			$ hg status --change 1
	M b2			M b2
	A 1k			A 1k
	A 2k			A 2k
	A b2link (no-windows !)			A b2link (symlink !)
	A bin			A bin
	A c1			A c1
	A con.xml (no-windows !)			A con.xml (no-windows !)
	R a2			R a2
	$ hg status --change 2			$ hg status --change 2
	M b2			M b2
	$ hg status --change 3			$ hg status --change 3
	M b2			M b2
	A 1k			A 1k
	A 2k			A 2k
	A b2link (no-windows !)			A b2link (symlink !)
	A bin			A bin
	A c1			A c1
	A con.xml (no-windows !)			A con.xml (no-windows !)
	R a2			R a2
	$ hg status --change 4			$ hg status --change 4
	A .hgsub			A .hgsub
	A .hgsubstate			A .hgsubstate
	$ hg status			$ hg status

	test with multi revs revset			test with multi revs revset
	---------------------------			---------------------------
	$ hg status --added --rev 0:1 --rev 3:4			$ hg status --added --rev 0:1 --rev 3:4
	A .hgsub			A .hgsub
	A .hgsubstate			A .hgsubstate
	A 1k			A 1k
	A 2k			A 2k
	A b2link (no-windows !)			A b2link (symlink !)
	A bin			A bin
	A c1			A c1
	A con.xml (no-windows !)			A con.xml (no-windows !)
	$ fileset "status('0:1', '3:4', added())"			$ fileset "status('0:1', '3:4', added())"
	.hgsub			.hgsub
	.hgsubstate			.hgsubstate
	1k			1k
	2k			2k
	b2link (no-windows !)			b2link (symlink !)
	bin			bin
	c1			c1
	con.xml (no-windows !)			con.xml (no-windows !)

	tests with empty value			tests with empty value
	----------------------			----------------------

	Fully empty revset			Fully empty revset

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17561		Nov 5 2019, 6:35 PM	★	★
Diff 2	17582	rHG0a0bad6d7ac03ed3354accf5308adeed989314ce	Nov 5 2019, 6:25 PM	★	★