I would like to clean up the changelog class by moving out knowledge
of filtering. The filtering will instead be done in a class that wraps
the changelog. This patch prepares for that.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/repoview.py (7 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz | ||
| Closed | martinvonz |
| cache it's result""" | cache it's result""" | ||||
| if filtername not in repo.filteredrevcache: | if filtername not in repo.filteredrevcache: | ||||
| func = filtertable[filtername] | func = filtertable[filtername] | ||||
| if visibilityexceptions: | if visibilityexceptions: | ||||
| return func(repo.unfiltered, visibilityexceptions) | return func(repo.unfiltered, visibilityexceptions) | ||||
| repo.filteredrevcache[filtername] = func(repo.unfiltered()) | repo.filteredrevcache[filtername] = func(repo.unfiltered()) | ||||
| return repo.filteredrevcache[filtername] | return repo.filteredrevcache[filtername] | ||||
| def wrapchangelog(unfichangelog, filteredrevs): | |||||
| cl = copy.copy(unfichangelog) | |||||
| cl.filteredrevs = filteredrevs | |||||
| return cl | |||||
| class repoview(object): | class repoview(object): | ||||
| """Provide a read/write view of a repo through a filtered changelog | """Provide a read/write view of a repo through a filtered changelog | ||||
| This object is used to access a filtered version of a repository without | This object is used to access a filtered version of a repository without | ||||
| altering the original repository object itself. We can not alter the | altering the original repository object itself. We can not alter the | ||||
| original object for two main reasons: | original object for two main reasons: | ||||
| - It prevents the use of a repo with multiple filters at the same time. In | - It prevents the use of a repo with multiple filters at the same time. In | ||||
| # if cl.index is not unfiindex, unfi.changelog would be | # if cl.index is not unfiindex, unfi.changelog would be | ||||
| # recreated, and our clcache refers to garbage object | # recreated, and our clcache refers to garbage object | ||||
| if cl is not None and ( | if cl is not None and ( | ||||
| cl.index is not unfiindex or newkey != self._clcachekey | cl.index is not unfiindex or newkey != self._clcachekey | ||||
| ): | ): | ||||
| cl = None | cl = None | ||||
| # could have been made None by the previous if | # could have been made None by the previous if | ||||
| if cl is None: | if cl is None: | ||||
| cl = copy.copy(unfichangelog) | cl = wrapchangelog(unfichangelog, revs) | ||||
| cl.filteredrevs = revs | |||||
| object.__setattr__(self, r'_clcache', cl) | object.__setattr__(self, r'_clcache', cl) | ||||
| object.__setattr__(self, r'_clcachekey', newkey) | object.__setattr__(self, r'_clcachekey', newkey) | ||||
| return cl | return cl | ||||
| def unfiltered(self): | def unfiltered(self): | ||||
| """Return an unfiltered version of a repo""" | """Return an unfiltered version of a repo""" | ||||
| return self._unfilteredrepo | return self._unfilteredrepo | ||||