This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7364

repoview: use class literal for creating filteredchangelog
ClosedPublic

Authored by martinvonz on Nov 8 2019, 2:26 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG85628a595c37: repoview: use class literal for creating filteredchangelog
rHGd1b8fcc38991: repoview: use class literal for creating filteredchangelog
Summary

The type name is constant, so we don't need to create it dynamically
using type(). As suggested by Yuya.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/repoview.py (7 lines)

Diff 17801

mercurial/repoview.py

repo.filteredrevcache[filtername] = func(repo.unfiltered()) repo.filteredrevcache[filtername] = func(repo.unfiltered())
return repo.filteredrevcache[filtername] return repo.filteredrevcache[filtername]
def wrapchangelog(unfichangelog, filteredrevs): def wrapchangelog(unfichangelog, filteredrevs):
cl = copy.copy(unfichangelog) cl = copy.copy(unfichangelog)
cl.filteredrevs = filteredrevs cl.filteredrevs = filteredrevs
cl.__class__ = type( class filteredchangelog(filteredchangelogmixin, cl.__class__):
'filteredchangelog', (filteredchangelogmixin, cl.__class__), {} pass
)
cl.__class__ = filteredchangelog
return cl return cl
class filteredchangelogmixin(object): class filteredchangelogmixin(object):
def tiprev(self): def tiprev(self):
"""filtered version of revlog.tiprev""" """filtered version of revlog.tiprev"""
for i in pycompat.xrange(len(self) - 1, -2, -1): for i in pycompat.xrange(len(self) - 1, -2, -1):