This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7368

fuzz: migrate bdiff fuzzer to use FuzzedDataProvider
ClosedPublic

Authored by durin42 on Nov 11 2019, 5:02 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGdbc39f028c9f: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 11 2019, 5:02 PM
indygreg accepted this revision.Nov 11 2019, 10:00 PM
indygreg added a subscriber: indygreg.

Not much context was given in the commit message. But if this makes our automated fuzzing overlords happier, then I suppose this is fine.

This revision is now accepted and ready to land.Nov 11 2019, 10:00 PM
durin42 added a commit: rHGdbc39f028c9f: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider.Nov 11 2019, 10:03 PM
Closed by commit rHGdbc39f028c9f: fuzz: migrate bdiff fuzzer to use FuzzedDataProvider (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/fuzz/bdiff.cc (14 lines)

Diff 18035

contrib/fuzz/bdiff.cc

/* /*
* bdiff.cc - fuzzer harness for bdiff.c * bdiff.cc - fuzzer harness for bdiff.c
* *
* Copyright 2018, Google Inc. * Copyright 2018, Google Inc.
* *
* This software may be used and distributed according to the terms of * This software may be used and distributed according to the terms of
* the GNU General Public License, incorporated herein by reference. * the GNU General Public License, incorporated herein by reference.
*/ */
#include <memory> #include <memory>
#include <stdlib.h> #include <stdlib.h>
#include "fuzzutil.h" #include <fuzzer/FuzzedDataProvider.h>
extern "C" { extern "C" {
#include "bdiff.h" #include "bdiff.h"
int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size)
{ {
auto maybe_inputs = SplitInputs(Data, Size); FuzzedDataProvider provider(Data, Size);
if (!maybe_inputs) { std::string left = provider.ConsumeRandomLengthString(Size);
return 0; std::string right = provider.ConsumeRemainingBytesAsString();
}
auto inputs = std::move(maybe_inputs.value());
struct bdiff_line *a, *b; struct bdiff_line *a, *b;
int an = bdiff_splitlines(inputs.left.get(), inputs.left_size, &a); int an = bdiff_splitlines(left.c_str(), left.size(), &a);
int bn = bdiff_splitlines(inputs.right.get(), inputs.right_size, &b); int bn = bdiff_splitlines(right.c_str(), right.size(), &b);
struct bdiff_hunk l; struct bdiff_hunk l;
bdiff_diff(a, an, b, bn, &l); bdiff_diff(a, an, b, bn, &l);
free(a); free(a);
free(b); free(b);
bdiff_freehunks(l.next); bdiff_freehunks(l.next);
return 0; // Non-zero return values are reserved for future use. return 0; // Non-zero return values are reserved for future use.
} }