directaccess: add support for accessing hidden commits if command is read only
AbandonedPublic
Actions

Authored by pulkit on Sep 19 2017, 9:36 PM.

Details

Reviewers

Group Reviewers

Summary

This patch adds support for accessing hidden commits by read only commands. It
introduces a new config experimental.directaccess which can be set to true to
access the hidden commits.

Currently this supports revision numbers also which may don't want to support.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

pulkit created this revision.Sep 19 2017, 9:36 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptSep 19 2017, 9:36 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

pulkit added a child revision: D738: directaccess: add support to export and tests to demonstrate things.Sep 19 2017, 9:36 PM

pulkit mentioned this in D614: registrar: make cmdtype an attribute of the function in registar.command.Sep 19 2017, 9:38 PM

pulkit mentioned this in D696: registrar: add a enum 'cmdtype' for the type of the command.

pulkit mentioned this in D612: command: add a cmdtype argument to registrar.command.Sep 19 2017, 9:40 PM

Probably needs a simple test, unless that comes later in the series.

mercurial/dispatch.py
898	This seems overly broad. 'hg log' is a readonly command, and if I do 'hg log -r HIDDEN_HASH' I want to see the hidden commit, but if I do 'hg log' I don't want to see hidden commits. I think this change would cause hg log to show all hidden commits right?

This revision now requires changes to proceed.Sep 26 2017, 8:16 AM

pulkit abandoned this revision.Oct 10 2017, 5:31 PM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/dispatch.py (6 lines)

Status	Author	Revision
Abandoned	pulkit	D1014 revset: update repo._pinnedrevs with hidden commits from the tree
Abandoned	pulkit	D1013 dispatch: filter the repository depending on func.cmdtype
Abandoned	pulkit	D738 directaccess: add support to export and tests to demonstrate things
Abandoned	pulkit	D737 directaccess: add support for accessing hidden commits if command is read only
Closed	pulkit	D736 registrar: add support for storing the type of command in func object

Diff 1905

View Options

directaccess: add support for accessing hidden commits if command is read onlyAbandonedPublicActions