This is an archive of the discontinued Mercurial Phabricator instance.

Differential D737

directaccess: add support for accessing hidden commits if command is read only
AbandonedPublic

Authored by pulkit on Sep 19 2017, 9:36 PM.

Details

Reviewers
durham
Group Reviewers
hg-reviewers
Summary

This patch adds support for accessing hidden commits by read only commands. It
introduces a new config experimental.directaccess which can be set to true to
access the hidden commits.

Currently this supports revision numbers also which may don't want to support.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Sep 19 2017, 9:36 PM
durham requested changes to this revision.Sep 26 2017, 8:16 AM
durham added a subscriber: durham.

Probably needs a simple test, unless that comes later in the series.

mercurial/dispatch.py
898

This seems overly broad. 'hg log' is a readonly command, and if I do 'hg log -r HIDDEN_HASH' I want to see the hidden commit, but if I do 'hg log' I don't want to see hidden commits. I think this change would cause hg log to show all hidden commits right?

This revision now requires changes to proceed.Sep 26 2017, 8:16 AM
pulkit abandoned this revision.Oct 10 2017, 5:31 PM

Revision Contents
Changeset List

Diff 1905

mercurial/dispatch.py

pycompat, pycompat,
registrar, registrar,
scmutil, scmutil,
ui as uimod, ui as uimod,
util, util,
) )
unrecoverablewrite = registrar.command.unrecoverablewrite unrecoverablewrite = registrar.command.unrecoverablewrite
readonly = registrar.command.readonly
class request(object): class request(object):
def __init__(self, args, ui=None, repo=None, fin=None, fout=None, def __init__(self, args, ui=None, repo=None, fin=None, fout=None,
ferr=None, prereposetups=None): ferr=None, prereposetups=None):
self.args = args self.args = args
self.ui = ui self.ui = ui
self.repo = repo self.repo = repo
raise error.RepoError(_("no repository found in" raise error.RepoError(_("no repository found in"
" '%s' (.hg not found)") " '%s' (.hg not found)")
% pycompat.getcwd()) % pycompat.getcwd())
raise raise
if repo: if repo:
ui = repo.ui ui = repo.ui
if options['hidden']: if options['hidden']:
repo = repo.unfiltered() repo = repo.unfiltered()
# Accesing hidden commits based on func.cmdtype
if lui.configbool('experimental', 'directaccess', False):
cmdtype = func.cmdtype
if cmdtype == readonly:
repo = repo.unfiltered()
durhamUnsubmitted
Not Done

This seems overly broad. 'hg log' is a readonly command, and if I do 'hg log -r HIDDEN_HASH' I want to see the hidden commit, but if I do 'hg log' I don't want to see hidden commits. I think this change would cause hg log to show all hidden commits right?

durham: This seems overly broad. 'hg log' is a readonly command, and if I do 'hg log -r HIDDEN_HASH' I…
args.insert(0, repo) args.insert(0, repo)
elif rpath: elif rpath:
ui.warn(_("warning: --repository ignored\n")) ui.warn(_("warning: --repository ignored\n"))
msg = _formatargs(fullargs) msg = _formatargs(fullargs)
ui.log("command", '%s\n', msg) ui.log("command", '%s\n', msg)
strcmdopt = pycompat.strkwargs(cmdoptions) strcmdopt = pycompat.strkwargs(cmdoptions)
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt) d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)