This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7375

py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg
ClosedPublic

Authored by martinvonz on Nov 13 2019, 1:28 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG975e517451a6: py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 13 2019, 1:28 PM
durin42 added a subscriber: durin42.Nov 13 2019, 5:59 PM

I feel obligated to point out that this will result in different (wrong!) quoting if path contains a ', but that's also probably fine since it's just a log.

martinvonz added a comment.Nov 13 2019, 6:07 PM
In D7375#108431, @durin42 wrote:

I feel obligated to point out that this will result in different (wrong!) quoting if path contains a ', but that's also probably fine since it's just a log.

Oh, good to know! I had no idea that %r does escaping too.

martinvonz added a commit: rHG975e517451a6: py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg.Nov 13 2019, 6:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG975e517451a6: py3: replace "%r" by"'%s'% for py3-compatible (and clearer) quoting in chg (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/chgserver.py (2 lines)

Diff 18057

mercurial/chgserver.py

"""Change current directory """Change current directory
Note that the behavior of --cwd option is bit different from this. Note that the behavior of --cwd option is bit different from this.
It does not affect --config parameter. It does not affect --config parameter.
""" """
path = self._readstr() path = self._readstr()
if not path: if not path:
return return
self.ui.log(b'chgserver', b'chdir to %r\n', path) self.ui.log(b'chgserver', b"chdir to '%s'\n", path)
os.chdir(path) os.chdir(path)
def setumask(self): def setumask(self):
"""Change umask (DEPRECATED)""" """Change umask (DEPRECATED)"""
# BUG: this does not follow the message frame structure, but kept for # BUG: this does not follow the message frame structure, but kept for
# backward compatibility with old chg clients for some time # backward compatibility with old chg clients for some time
self._setumask(self._read(4)) self._setumask(self._read(4))