This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7428

tags: don't check for clean files when checking for dirty working copy
ClosedPublic

Authored by martinvonz on Nov 15 2019, 1:04 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf7d7f9d23a7a: tags: don't check for clean files when checking for dirty working copy
Summary

We didn't request status for clean files so there should never be any
entries in the list of clean files (at least not since dd773340a085),
but it's misleading to check the list.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 15 2019, 1:04 AM
pulkit accepted this revision.Nov 15 2019, 6:22 PM
This revision is now accepted and ready to land.Nov 15 2019, 6:22 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/tags.py (1 line)

Diff 18212

mercurial/tags.py

if any( if any(
( (
st.modified, st.modified,
st.added, st.added,
st.removed, st.removed,
st.deleted, st.deleted,
st.unknown, st.unknown,
st.ignored, st.ignored,
st.clean,
) )
): ):
raise error.Abort( raise error.Abort(
_(b'working copy of .hgtags is changed'), _(b'working copy of .hgtags is changed'),
hint=_(b'please commit .hgtags manually'), hint=_(b'please commit .hgtags manually'),
) )
with repo.wlock(): with repo.wlock():