This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7447

tests: verify that Python scripts are blackened
ClosedPublic

Authored by indygreg on Nov 16 2019, 3:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2d8d4e08c493: tests: verify that Python scripts are blackened
Summary

Scripts are Python too. They should be blackened.

(As suggested by Pierre-Yves in D7420.)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 16 2019, 3:08 PM
pulkit accepted this revision.Nov 18 2019, 11:14 AM
This revision is now accepted and ready to land.Nov 18 2019, 11:14 AM
indygreg added a commit: rHG2d8d4e08c493: tests: verify that Python scripts are blackened.Nov 18 2019, 11:50 AM
Closed by commit rHG2d8d4e08c493: tests: verify that Python scripts are blackened (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18215

tests/test-check-format.t

#require black #require black
$ cd $RUNTESTDIR/.. $ cd $RUNTESTDIR/..
$ black --config=black.toml --check --diff `hg files 'set:**.py - mercurial/thirdparty/** - "contrib/python-zstandard/**"'` $ black --config=black.toml --check --diff `hg files 'set:(**.py + grep("^#!.*python")) - mercurial/thirdparty/** - "contrib/python-zstandard/**"'`

tests/test-check-shbang.t

#require test-repo #require test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
look for python scripts that do not use /usr/bin/env look for python scripts that do not use /usr/bin/env
$ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t' $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t'
[1] [1]
In tests, enforce $PYTHON and *not* /usr/bin/env python or similar: In tests, enforce $PYTHON and *not* /usr/bin/env python or similar:
$ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \ $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \
> -X tests/test-check-execute.t \ > -X tests/test-check-execute.t \
> -X tests/test-check-format.t \
> -X tests/test-check-module-imports.t \ > -X tests/test-check-module-imports.t \
> -X tests/test-check-pyflakes.t \ > -X tests/test-check-pyflakes.t \
> -X tests/test-check-shbang.t > -X tests/test-check-shbang.t
[1] [1]
The above exclusions are because they're looking for files that The above exclusions are because they're looking for files that
contain Python but don't end in .py - please avoid adding more. contain Python but don't end in .py - please avoid adding more.
look for shell scripts that do not use /bin/sh look for shell scripts that do not use /bin/sh
$ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")' $ testrepohg files 'set:grep(r"^#!.*/bi{1}n/sh") and not grep(r"^#!/bi{1}n/sh")'
[1] [1]