This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7453

py3: pass bytes to `configint` and `configbool`
ClosedPublic

Authored by Alphare on Nov 18 2019, 11:44 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG794426e96970: py3: pass bytes to `configint` and `configbool`
Summary

Both functions require bytes, even in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Nov 18 2019, 11:44 AM
indygreg accepted this revision.Nov 18 2019, 10:38 PM
This revision is now accepted and ready to land.Nov 18 2019, 10:38 PM
Alphare added a commit: rHG794426e96970: py3: pass bytes to `configint` and `configbool`.Nov 18 2019, 10:49 PM
Closed by commit rHG794426e96970: py3: pass bytes to `configint` and `configbool` (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (4 lines)

Diff 18219

mercurial/dirstate.py

elif not match.always(): elif not match.always():
# Matchers have yet to be implemented # Matchers have yet to be implemented
use_rust = False use_rust = False
if use_rust: if use_rust:
# Force Rayon (Rust parallelism library) to respect the number of # Force Rayon (Rust parallelism library) to respect the number of
# workers. This is a temporary workaround until Rust code knows # workers. This is a temporary workaround until Rust code knows
# how to read the config file. # how to read the config file.
numcpus = self._ui.configint("worker", "numcpus") numcpus = self._ui.configint(b"worker", b"numcpus")
if numcpus is not None: if numcpus is not None:
encoding.environ.setdefault( encoding.environ.setdefault(
b'RAYON_NUM_THREADS', b'%d' % numcpus b'RAYON_NUM_THREADS', b'%d' % numcpus
) )
workers_enabled = self._ui.configbool("worker", "enabled", True) workers_enabled = self._ui.configbool(b"worker", b"enabled", True)
if not workers_enabled: if not workers_enabled:
encoding.environ[b"RAYON_NUM_THREADS"] = b"1" encoding.environ[b"RAYON_NUM_THREADS"] = b"1"
( (
lookup, lookup,
modified, modified,
added, added,
removed, removed,