This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7471

tests: byteify a few more things in simplestorerepo.py
ClosedPublic

Authored by mharbison72 on Nov 21 2019, 6:23 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG8ca92bcb3083: tests: byteify a few more things in simplestorerepo.py

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Nov 21 2019, 6:23 PM
indygreg accepted this revision.Nov 21 2019, 9:50 PM
This revision is now accepted and ready to land.Nov 21 2019, 9:50 PM

Revision Contents
Changeset List

Diff 18275

tests/simplestorerepo.py

storageutil, storageutil,
) )
from mercurial.revlogutils import flagutil from mercurial.revlogutils import flagutil
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = b'ships-with-hg-core'
REQUIREMENT = 'testonly-simplestore' REQUIREMENT = b'testonly-simplestore'
def validatenode(node): def validatenode(node):
if isinstance(node, int): if isinstance(node, int):
raise ValueError('expected node; got int') raise ValueError('expected node; got int')
if len(node) != 20: if len(node) != 20:
raise ValueError('expected 20 byte node') raise ValueError('expected 20 byte node')
self._indexbynode[node] self._indexbynode[node]
except KeyError: except KeyError:
raise error.LookupError(node, self._indexpath, _('no node')) raise error.LookupError(node, self._indexpath, _('no node'))
for rev, entry in self._indexbyrev.items(): for rev, entry in self._indexbyrev.items():
if entry[b'node'] == node: if entry[b'node'] == node:
return rev return rev
raise error.ProgrammingError('this should not occur') raise error.ProgrammingError(b'this should not occur')
def node(self, rev): def node(self, rev):
validaterev(rev) validaterev(rev)
return self._indexbyrev[rev][b'node'] return self._indexbyrev[rev][b'node']
def hasnode(self, node): def hasnode(self, node):
validatenode(node) validatenode(node)