Page MenuHomePhabricator

repoview: add a test for changelog filtering trigger for `hg annotate`
AbandonedPublic

Authored by marmoute on Nov 22 2019, 4:22 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

marmoute created this revision.Nov 22 2019, 4:22 AM

Could we just add all these tests from the beginning? It seems they would look almost the same if added early in the series, just with some extra "getting filtered repo" lines (or whatever they say). If the tests were added earlier, it would be clearer which changes affected which tests.

Yes we could. (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)

Yes we could.

Please do if you don't mind. Thanks.

(right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)

Yes, I noticed.

marmoute abandoned this revision.Nov 23 2019, 8:07 AM

This was pruned, but phab apparently does not detect this.