This is an archive of the discontinued Mercurial Phabricator instance.

Could we just add all these tests from the beginning? It seems they would look almost the same if added early in the series, just with some extra "getting filtered repo" lines (or whatever they say). If the tests were added earlier, it would be clearer which changes affected which tests.

Yes we could. (right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)

In D7500#110252, @marmoute wrote:

Yes we could.

Please do if you don't mind. Thanks.

(right now, the test are introduced right before the series of change fixing it (or right after the last chngeset in that series)

Yes, I noticed.

marmoute removed a child revision: D7501: changectx: use unfiltered changelog to walk ancestors in annotate.Nov 23 2019, 6:54 AM

This was pruned, but phab apparently does not detect this.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-repo-filters-tiptoe.t (16 lines)

Commit	Parents	Author	Summary	Date
1855cf9a074e	5e27a0705de0	Pierre-Yves David		Nov 21 2019, 11:43 AM

Status	Author	Revision
Abandoned	marmoute	D7485 repoview: test filtered computation on `hg status --change` call
Abandoned	marmoute	D7489 repoview: add test for filtering computation when running `hg status`
Abandoned	marmoute	D7493 repoview: test changelog filtering triggered by a lookup to '.'
Abandoned	marmoute	D7497 repoview: add a test for filtering computation for `hg diff --change`
Abandoned	marmoute	D7496 repoview: add a test for filtering computation for `hg diff`
Closed	marmoute	D7502 changectx: mark parent of changesets as non filtered
Closed	marmoute	D7501 changectx: use unfiltered changelog to walk ancestors in annotate
Abandoned	marmoute	D7500 repoview: add a test for changelog filtering trigger for `hg annotate`
Abandoned	marmoute	D7499 repoview: test triggering of filter computation for `hg export`
Closed	marmoute	D7498 localrepo: also fast past the parents of working copies parents
Closed	marmoute	D7495 localrepo: recognize trivial request for '.'
Closed	marmoute	D7494 localrepo: fastpath access to "."
Closed	marmoute	D7492 localrepo: also fastpath access to working copy parents when possible
Closed	marmoute	D7491 changectx: mark the parents of the working copy as non filtered
Closed	marmoute	D7490 repoview: add an explicit set of all filter that show the wc parents
Closed	marmoute	D7488 localrepo: introduce a `_quick_access_changeid` property
Closed	marmoute	D7487 changectx: use unfiltered changelog to access parents of unfiltered revs
Closed	marmoute	D7486 locarepo: also fastpath `nullid` lookup in __getitem__
Closed	marmoute	D7484 localrepo: mark nullrev has never filtered
Closed	marmoute	D7483 changectx: add a "maybe filtered" filtered attribute
Closed	marmoute	D7514 repoview: add more tests to track operation not supposed to trigger filtering

Diff 18307

tests/test-repo-filters-tiptoe.t

	+c			+c
	diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 z			diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 z
	--- a/z Thu Jan 01 00:00:00 1970 +0000			--- a/z Thu Jan 01 00:00:00 1970 +0000
	+++ b/z Thu Jan 01 00:00:00 1970 +0000			+++ b/z Thu Jan 01 00:00:00 1970 +0000
	@@ -1,2 +1,3 @@			@@ -1,2 +1,3 @@
	some line			some line
	in a			in a
	+file			+file

				using annotate

				- file with a single change

				$ hg annotate a
				debug.filters: computing revision filter for "visible"
				0: a

				- file with multiple change

				$ hg annotate z
				debug.filters: computing revision filter for "visible"
				0: some line
				1: in a
				2: file

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18307			Nov 22 2019, 4:22 AM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

repoview: add a test for changelog filtering trigger for `hg annotate`AbandonedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18307

tests/test-repo-filters-tiptoe.t

repoview: add a test for changelog filtering trigger for `hg annotate`
AbandonedPublic

Revision Contents
Changeset List