This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7520

dateutil: correct default for Ymd in parsedate
ClosedPublic

Authored by quark on Nov 25 2019, 3:50 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb65bd4b61d78: dateutil: correct default for Ymd in parsedate
rHGaef7b91dba51: dateutil: correct default for Ymd in parsedate
Summary

The code uses 0 for the default value of Ymd (year, month, and day), which
seems suboptimal. For example, these will fail to parse:

dateutil.parsedate('2000', formats=dateutil.extendeddateformats)
dateutil.parsedate('Jan 2000', formats=dateutil.extendeddateformats)

Fix it by providing sane defaults (1 instead of 0) for year, month, and day.

The suboptimal behavior was introduced by 91bc001a592 (2010-12-29,
"date: fix matching of underspecified date ranges"), which does not seem to
justify the current behavior.

Note end-users should not notice the subtle issue, because there are no formats
in defaultdateformats that allow an explicit year with omitted month, or an
explicit month with omitted day.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Nov 25 2019, 3:50 PM
pulkit accepted this revision.Nov 26 2019, 9:18 AM
This revision is now accepted and ready to land.Nov 26 2019, 9:18 AM
quark added a commit: rHGaef7b91dba51: dateutil: correct default for Ymd in parsedate.Nov 26 2019, 9:48 AM
Closed by commit rHGaef7b91dba51: dateutil: correct default for Ymd in parsedate (authored by quark). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/dateutil.py (5 lines)

Diff 18396

mercurial/utils/dateutil.py

... ).strftime('%b %d').encode('ascii')) ... ).strftime('%b %d').encode('ascii'))
True True
>>> now, tz = makedate() >>> now, tz = makedate()
>>> strnow, strtz = parsedate(b'now') >>> strnow, strtz = parsedate(b'now')
>>> (strnow - now) < 1 >>> (strnow - now) < 1
True True
>>> tz == strtz >>> tz == strtz
True True
>>> parsedate(b'2000 UTC', formats=extendeddateformats)
(946684800, 0)
""" """
if bias is None: if bias is None:
bias = {} bias = {}
if not date: if not date:
return 0, 0 return 0, 0
if isinstance(date, tuple) and len(date) == 2: if isinstance(date, tuple) and len(date) == 2:
return date return date
if not formats: if not formats:
defaults = {} defaults = {}
for part in (b"d", b"mb", b"yY", b"HI", b"M", b"S"): for part in (b"d", b"mb", b"yY", b"HI", b"M", b"S"):
# this piece is for rounding the specific end of unknowns # this piece is for rounding the specific end of unknowns
b = bias.get(part) b = bias.get(part)
if b is None: if b is None:
if part[0:1] in b"HMS": if part[0:1] in b"HMS":
b = b"00" b = b"00"
else: else:
b = b"0" # year, month, and day start from 1
b = b"1"
# this piece is for matching the generic end to today's date # this piece is for matching the generic end to today's date
n = datestr(now, b"%" + part[0:1]) n = datestr(now, b"%" + part[0:1])
defaults[part] = (b, n) defaults[part] = (b, n)
for format in formats: for format in formats:
try: try: