( )⚙ D7546 exchange: replace a "not x in ys" by more Pythonic "x not in ys"

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7546

exchange: replace a "not x in ys" by more Pythonic "x not in ys"
ClosedPublic

Authored by martinvonz on Dec 5 2019, 12:03 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG0f6782df1100: exchange: replace a "not x in ys" by more Pythonic "x not in ys"
Summary

Found by one of our (Google-)internal tools.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Dec 5 2019, 12:03 PM
pulkit accepted this revision.Dec 6 2019, 8:56 AM
This revision is now accepted and ready to land.Dec 6 2019, 8:56 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/exchange.py (2 lines)

Diff 18471

mercurial/exchange.py

@getbundle2partsgenerator(b'phases') @getbundle2partsgenerator(b'phases')
def _getbundlephasespart( def _getbundlephasespart(
bundler, repo, source, bundlecaps=None, b2caps=None, heads=None, **kwargs bundler, repo, source, bundlecaps=None, b2caps=None, heads=None, **kwargs
): ):
"""add phase heads part to the requested bundle""" """add phase heads part to the requested bundle"""
if kwargs.get('phases', False): if kwargs.get('phases', False):
if not b2caps or not b'heads' in b2caps.get(b'phases'): if not b2caps or b'heads' not in b2caps.get(b'phases'):
raise error.Abort(_(b'no common phases exchange method')) raise error.Abort(_(b'no common phases exchange method'))
if heads is None: if heads is None:
heads = repo.heads() heads = repo.heads()
headsbyphase = collections.defaultdict(set) headsbyphase = collections.defaultdict(set)
if repo.publishing(): if repo.publishing():
headsbyphase[phases.public] = heads headsbyphase[phases.public] = heads
else: else: