This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7618

fix: correct the clang-format example hgrc so that it actually works
ClosedPublic

Authored by spectral on Dec 12 2019, 5:42 PM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHGac72e17457e5: fix: correct the clang-format example hgrc so that it actually works
rHG7a16c779a9d0: fix: correct the clang-format example hgrc so that it actually works

Summary

There are three changes here:

Remove -i from command, it causes fix to eat your file and empty it out
Add set: to pattern, otherwise this is interpreted as just a glob
Switch listfile: to include:; listfile: is relative to the current working directory, while include: is relative to the repo root. This makes it so that you don't receive errors when running outside of the repo root about being unable to find the file.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Dec 12 2019, 5:42 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptDec 12 2019, 5:42 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

spectral added a child revision: D7619: fix: convert clang-format-ignorelist to use wildcards.Dec 12 2019, 5:42 PM

spectral updated this revision to Diff 18660.Dec 12 2019, 7:34 PM

Remove -i from command, it causes fix to eat your file and empty it out

We should add a prompt/warning in hg fix when it empties the file.

This revision is now accepted and ready to land.Dec 20 2019, 7:24 AM

spectral added a commit: rHG7a16c779a9d0: fix: correct the clang-format example hgrc so that it actually works.Jan 8 2020, 11:50 AM

Closed by commit rHG7a16c779a9d0: fix: correct the clang-format example hgrc so that it actually works (authored by spectral). · Explain Why

This revision was automatically updated to reflect the committed changes.

spectral added a commit: rHGac72e17457e5: fix: correct the clang-format example hgrc so that it actually works.Jan 8 2020, 1:10 PM

Revision Contents
Changeset List

			Path	Packages
M			contrib/examples/fix.hgrc (4 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	18648		Dec 12 2019, 5:42 PM	★	★
Diff 2	18660		Dec 12 2019, 7:34 PM	★	★
Diff 3	19071	rHG7a16c779a9d071cfe0a61e3c2a480c8e56defb00	Dec 12 2019, 5:28 PM	★	★

Status	Author	Revision
Closed	spectral	D7619 fix: convert clang-format-ignorelist to use wildcards
Closed	spectral	D7618 fix: correct the clang-format example hgrc so that it actually works
Abandoned	spectral	D7617 fix: make example fix hgrc work in subdirs

Diff 19071

contrib/examples/fix.hgrc

	[fix]			[fix]
	clang-format:command = clang-format --style file -i			clang-format:command = clang-format --style file
	clang-format:pattern = (.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"			clang-format:pattern = set:(.c or .cc or **.h) and not "include:contrib/clang-format-ignorelist"

	rustfmt:command = rustfmt			rustfmt:command = rustfmt
	rustfmt:pattern = set:**.rs			rustfmt:pattern = set:**.rs

	black:command = black --config=black.toml -			black:command = black --config=black.toml -
	black:pattern = set:.py - mercurial/thirdparty/ - "contrib/python-zstandard/**"			black:pattern = set:.py - mercurial/thirdparty/ - "contrib/python-zstandard/**"

	# Mercurial doesn't have any Go code, but if we did this is how we			# Mercurial doesn't have any Go code, but if we did this is how we
	# would configure `hg fix` for Go:			# would configure `hg fix` for Go:
	go:command = gofmt			go:command = gofmt
	go:pattern = set:**.go			go:pattern = set:**.go