This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7638

fix: use cmdutil.check_at_most_one_arg()
ClosedPublic

Authored by martinvonz on Dec 13 2019, 2:53 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGdda49ec2b54a: fix: use cmdutil.check_at_most_one_arg()

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Dec 13 2019, 2:53 AM
martinvonz retitled this revision from fix: use cmdutil.check_unique_argument() to fix: use cmdutil.check_at_most_one_arg().Dec 16 2019, 6:18 PM
martinvonz updated this revision to Diff 18764.
pulkit accepted this revision.Dec 17 2019, 2:12 AM
This revision is now accepted and ready to land.Dec 17 2019, 2:12 AM
martinvonz added a commit: rHGdda49ec2b54a: fix: use cmdutil.check_at_most_one_arg().Dec 17 2019, 2:58 AM
Closed by commit rHGdda49ec2b54a: fix: use cmdutil.check_at_most_one_arg() (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (3 lines)

Diff 18673

hgext/fix.py

directory will update to the replacement revision. directory will update to the replacement revision.
When determining what lines of each file to fix at each revision, the whole When determining what lines of each file to fix at each revision, the whole
set of revisions being fixed is considered, so that fixes to earlier set of revisions being fixed is considered, so that fixes to earlier
revisions are not forgotten in later ones. The --base flag can be used to revisions are not forgotten in later ones. The --base flag can be used to
override this default behavior, though it is not usually desirable to do so. override this default behavior, though it is not usually desirable to do so.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
cmdutil.check_unique_argument(opts, b'all', b'rev')
if opts[b'all']: if opts[b'all']:
if opts[b'rev']:
raise error.Abort(_(b'cannot specify both "--rev" and "--all"'))
opts[b'rev'] = [b'not public() and not obsolete()'] opts[b'rev'] = [b'not public() and not obsolete()']
opts[b'working_dir'] = True opts[b'working_dir'] = True
with repo.wlock(), repo.lock(), repo.transaction(b'fix'): with repo.wlock(), repo.lock(), repo.transaction(b'fix'):
revstofix = getrevstofix(ui, repo, opts) revstofix = getrevstofix(ui, repo, opts)
basectxs = getbasectxs(repo, opts, revstofix) basectxs = getbasectxs(repo, opts, revstofix)
workqueue, numitems = getworkqueue( workqueue, numitems = getworkqueue(
ui, repo, pats, opts, revstofix, basectxs ui, repo, pats, opts, revstofix, basectxs
) )