This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7677

typing: suppress a warning that mercurial.windows.checkosfilename is missing
ClosedPublic

Authored by mharbison72 on Dec 15 2019, 11:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG09bcbeacedc7: typing: suppress a warning that mercurial.windows.checkosfilename is missing
Summary

This function is used to check filename portability everwhere, so it isn't
tucked into the windows.py module. I supposed the alternative is to move it and
then alias it in util. I'm guessing it was done like this to save an import.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2019, 11:12 PM
pulkit accepted this revision.Dec 16 2019, 12:56 AM
This revision is now accepted and ready to land.Dec 16 2019, 12:56 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (3 lines)

Diff 18752

mercurial/util.py

% t % t
) )
if pycompat.iswindows: if pycompat.iswindows:
checkosfilename = checkwinfilename checkosfilename = checkwinfilename
timer = time.clock timer = time.clock
else: else:
checkosfilename = platform.checkosfilename # mercurial.windows doesn't have platform.checkosfilename
checkosfilename = platform.checkosfilename # pytype: disable=module-attr
timer = time.time timer = time.time
if safehasattr(time, "perf_counter"): if safehasattr(time, "perf_counter"):
timer = time.perf_counter timer = time.perf_counter
def makelock(info, pathname): def makelock(info, pathname):
"""Create a lock file atomically if possible """Create a lock file atomically if possible