Page MenuHomePhabricator

windows: if username(uid=None) is loaded, just use getpass
ClosedPublic

Authored by durin42 on Dec 16 2019, 5:13 PM.

Details

Summary

This is at least consistent with what we do on other platforms in the
base case. I don't know enough about Windows to fill in other cases
that might exist here, but this at least should be a start.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Dec 16 2019, 5:13 PM
pulkit accepted this revision.Dec 17 2019, 2:58 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/windows.py
566–568

Nice, seems like the old documentation was wrong.

This revision is now accepted and ready to land.Dec 17 2019, 2:59 AM