( )⚙ D7679 windows: if username(uid=None) is loaded, just use getpass

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7679

windows: if username(uid=None) is loaded, just use getpass
ClosedPublic

Authored by durin42 on Dec 16 2019, 5:13 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1b26cb044097: windows: if username(uid=None) is loaded, just use getpass
Summary

This is at least consistent with what we do on other platforms in the
base case. I don't know enough about Windows to fill in other cases
that might exist here, but this at least should be a start.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Dec 16 2019, 5:13 PM
pulkit accepted this revision.Dec 17 2019, 2:58 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/windows.py
566

Nice, seems like the old documentation was wrong.

This revision is now accepted and ready to land.Dec 17 2019, 2:59 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/windows.py (3 lines)

Diff 18758

mercurial/windows.py

# windows.py - Windows utility function implementations for Mercurial # windows.py - Windows utility function implementations for Mercurial
# #
# Copyright 2005-2009 Matt Mackall <mpm@selenic.com> and others # Copyright 2005-2009 Matt Mackall <mpm@selenic.com> and others
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
import errno import errno
import getpass
import msvcrt import msvcrt
import os import os
import re import re
import stat import stat
import string import string
import sys import sys
from .i18n import _ from .i18n import _
dmap = {} dmap = {}
cache = dircache.setdefault(dir, dmap) cache = dircache.setdefault(dir, dmap)
yield cache.get(base, None) yield cache.get(base, None)
def username(uid=None): def username(uid=None):
"""Return the name of the user with the given uid. """Return the name of the user with the given uid.
If uid is None, return the name of the current user.""" If uid is None, return the name of the current user."""
pulkitUnsubmitted
Not Done

Nice, seems like the old documentation was wrong.

pulkit: Nice, seems like the old documentation was wrong.
if not uid:
return pycompat.fsencode(getpass.getuser())
return None return None
def groupname(gid=None): def groupname(gid=None):
"""Return the name of the group with the given gid. """Return the name of the group with the given gid.
If gid is None, return the name of the current group.""" If gid is None, return the name of the current group."""
return None return None