This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7681

pytype: suppress warnings about no 'open_binary' on importlib.resources
ClosedPublic

Authored by mharbison72 on Dec 16 2019, 11:46 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG4d59cc8bda65: pytype: suppress warnings about no 'open_binary' on importlib.resources
Summary

Fixes these pytype warnings:

line 43, in <module>: No attribute 'open_binary' on module 'importlib.resources' [module-attr]
line 47, in open_resource: No attribute 'open_binary' on module 'importlib.resources' [module-attr]

For some reason, I can't upgrade from 3.6.8 in my WSL environment.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/resourceutil.py (4 lines)

Diff 18785

mercurial/utils/resourceutil.py

datapath = os.path.dirname(pycompat.sysexecutable) datapath = os.path.dirname(pycompat.sysexecutable)
else: else:
datapath = os.path.dirname(os.path.dirname(pycompat.fsencode(__file__))) datapath = os.path.dirname(os.path.dirname(pycompat.fsencode(__file__)))
try: try:
import importlib import importlib
# Force loading of the resources module # Force loading of the resources module
importlib.resources.open_binary importlib.resources.open_binary # pytype: disable=module-attr
def open_resource(package, name): def open_resource(package, name):
package = b'mercurial.' + package package = b'mercurial.' + package
return importlib.resources.open_binary( return importlib.resources.open_binary( # pytype: disable=module-attr
pycompat.sysstr(package), pycompat.sysstr(name) pycompat.sysstr(package), pycompat.sysstr(name)
) )
except AttributeError: except AttributeError:
def _package_path(package): def _package_path(package):
return os.path.join(datapath, *package.split(b'.')) return os.path.join(datapath, *package.split(b'.'))
def open_resource(package, name): def open_resource(package, name):
path = os.path.join(_package_path(package), name) path = os.path.join(_package_path(package), name)
return open(path, 'rb') return open(path, 'rb')