( )⚙ D7768 commit: change default `editor` parameter to None

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7768

commit: change default `editor` parameter to None
ClosedPublic

Authored by mharbison72 on Dec 28 2019, 11:42 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3216cabffd4a: commit: change default `editor` parameter to None
Summary

Flagged by PyCharm as a boolean not being callable later where it is used.
There's no actual bug here because of if editor checks before using.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 28 2019, 11:42 AM
mharbison72 added a commit: rHG3216cabffd4a: commit: change default `editor` parameter to None.Jan 8 2020, 2:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3216cabffd4a: commit: change default `editor` parameter to None (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19097

mercurial/context.py

parents, parents,
text, text,
files, files,
filectxfn, filectxfn,
user=None, user=None,
date=None, date=None,
extra=None, extra=None,
branch=None, branch=None,
editor=False, editor=None,
): ):
super(memctx, self).__init__( super(memctx, self).__init__(
repo, text, user, date, extra, branch=branch repo, text, user, date, extra, branch=branch
) )
self._rev = None self._rev = None
self._node = None self._node = None
parents = [(p or nullid) for p in parents] parents = [(p or nullid) for p in parents]
p1, p2 = parents p1, p2 = parents
self, self,
repo, repo,
originalctx, originalctx,
parents=None, parents=None,
text=None, text=None,
user=None, user=None,
date=None, date=None,
extra=None, extra=None,
editor=False, editor=None,
): ):
if text is None: if text is None:
text = originalctx.description() text = originalctx.description()
super(metadataonlyctx, self).__init__(repo, text, user, date, extra) super(metadataonlyctx, self).__init__(repo, text, user, date, extra)
self._rev = None self._rev = None
self._node = None self._node = None
self._originalctx = originalctx self._originalctx = originalctx
self._manifestnode = originalctx.manifestnode() self._manifestnode = originalctx.manifestnode()

mercurial/localrepo.py

@unfilteredmethod @unfilteredmethod
def commit( def commit(
self, self,
text=b"", text=b"",
user=None, user=None,
date=None, date=None,
match=None, match=None,
force=False, force=False,
editor=False, editor=None,
extra=None, extra=None,
): ):
"""Add a new revision to current repository. """Add a new revision to current repository.
Revision information is gathered from the working directory, Revision information is gathered from the working directory,
match can be used to filter the committed files. If editor is match can be used to filter the committed files. If editor is
supplied, it is called to get a commit message. supplied, it is called to get a commit message.
""" """