Page MenuHomePhabricator

transaction: allow finalizer to add finalizer
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:02 PM.

Details

Summary

It will make some code (persistent nodemap related) simpler to write, because
higher level code can blindly queue finalization without thinking too hard about
the context.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 11 2020, 12:02 PM
martinvonz added inline comments.
mercurial/transaction.py
511

Any reason to not set this to None as we do on line 516? Also, can we remove that line now?

martinvonz accepted this revision.Jan 16 2020, 11:51 AM
martinvonz added inline comments.
mercurial/transaction.py
511

Ah, never mind, I just found the previous patch in this stack and now it's clear.

This revision is now accepted and ready to land.Jan 16 2020, 11:51 AM
This revision was automatically updated to reflect the committed changes.