This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7833

transaction: allow finalizer to add finalizer
ClosedPublic

Authored by marmoute on Jan 11 2020, 12:02 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG2f1d6180737f: transaction: allow finalizer to add finalizer
Summary

It will make some code (persistent nodemap related) simpler to write, because
higher level code can blindly queue finalization without thinking too hard about
the context.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 11 2020, 12:02 PM
martinvonz added a subscriber: martinvonz.Jan 16 2020, 11:49 AM
martinvonz added inline comments.
mercurial/transaction.py
511

Any reason to not set this to None as we do on line 516? Also, can we remove that line now?

martinvonz accepted this revision.Jan 16 2020, 11:51 AM
martinvonz added inline comments.
mercurial/transaction.py
511

Ah, never mind, I just found the previous patch in this stack and now it's clear.

This revision is now accepted and ready to land.Jan 16 2020, 11:51 AM
marmoute added a commit: rHG2f1d6180737f: transaction: allow finalizer to add finalizer.Jan 16 2020, 2:20 PM
Closed by commit rHG2f1d6180737f: transaction: allow finalizer to add finalizer (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (9 lines)

Diff 19378

mercurial/transaction.py

@active @active
def close(self): def close(self):
'''commit the transaction''' '''commit the transaction'''
if self._count == 1: if self._count == 1:
self._validator(self) # will raise exception if needed self._validator(self) # will raise exception if needed
self._validator = None # Help prevent cycles. self._validator = None # Help prevent cycles.
self._generatefiles(group=gengroupprefinalize) self._generatefiles(group=gengroupprefinalize)
categories = sorted(self._finalizecallback) while self._finalizecallback:
callbacks = self._finalizecallback
self._finalizecallback = {}
martinvonzUnsubmitted
Not Done

Any reason to not set this to None as we do on line 516? Also, can we remove that line now?

martinvonz: Any reason to not set this to `None` as we do on line 516? Also, can we remove that line now?
martinvonzUnsubmitted
Not Done

Ah, never mind, I just found the previous patch in this stack and now it's clear.

martinvonz: Ah, never mind, I just found the previous patch in this stack and now it's clear.
categories = sorted(callbacks)
for cat in categories: for cat in categories:
self._finalizecallback[cat](self) callbacks[cat](self)
# Prevent double usage and help clear cycles. # Prevent double usage and help clear cycles.
self._finalizecallback = None self._finalizecallback = None
self._generatefiles(group=gengrouppostfinalize) self._generatefiles(group=gengrouppostfinalize)
self._count -= 1 self._count -= 1
if self._count != 0: if self._count != 0:
return return
self._file.close() self._file.close()